Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Side by Side Diff: webrtc/pc/webrtcsession_unittest.cc

Issue 3005433002: Fix places that trigger no-unused-lambda-capture (Closed)
Patch Set: Rebased Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 3246 matching lines...) Expand 10 before | Expand all | Expand 10 after
3257 SetLocalDescriptionWithoutError(answer); 3257 SetLocalDescriptionWithoutError(answer);
3258 3258
3259 EXPECT_EQ(session_->voice_rtp_transport_channel(), 3259 EXPECT_EQ(session_->voice_rtp_transport_channel(),
3260 session_->video_rtp_transport_channel()); 3260 session_->video_rtp_transport_channel());
3261 3261
3262 cricket::BaseChannel* voice_channel = session_->voice_channel(); 3262 cricket::BaseChannel* voice_channel = session_->voice_channel();
3263 ASSERT_TRUE(voice_channel != NULL); 3263 ASSERT_TRUE(voice_channel != NULL);
3264 3264
3265 // Checks if one of the transport channels contains a connection using a given 3265 // Checks if one of the transport channels contains a connection using a given
3266 // port. 3266 // port.
3267 auto connection_with_remote_port = [this, voice_channel](int port) { 3267 auto connection_with_remote_port = [this](int port) {
3268 std::unique_ptr<webrtc::SessionStats> stats = session_->GetStats_s(); 3268 std::unique_ptr<webrtc::SessionStats> stats = session_->GetStats_s();
3269 for (auto& kv : stats->transport_stats) { 3269 for (auto& kv : stats->transport_stats) {
3270 for (auto& chan_stat : kv.second.channel_stats) { 3270 for (auto& chan_stat : kv.second.channel_stats) {
3271 for (auto& conn_info : chan_stat.connection_infos) { 3271 for (auto& conn_info : chan_stat.connection_infos) {
3272 if (conn_info.remote_candidate.address().port() == port) { 3272 if (conn_info.remote_candidate.address().port() == port) {
3273 return true; 3273 return true;
3274 } 3274 }
3275 } 3275 }
3276 } 3276 }
3277 } 3277 }
(...skipping 1288 matching lines...) Expand 10 before | Expand all | Expand 10 after
4566 } 4566 }
4567 4567
4568 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test 4568 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test
4569 // currently fails because upon disconnection and reconnection OnIceComplete is 4569 // currently fails because upon disconnection and reconnection OnIceComplete is
4570 // called more than once without returning to IceGatheringGathering. 4570 // called more than once without returning to IceGatheringGathering.
4571 4571
4572 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests, 4572 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests,
4573 WebRtcSessionTest, 4573 WebRtcSessionTest,
4574 testing::Values(ALREADY_GENERATED, 4574 testing::Values(ALREADY_GENERATED,
4575 DTLS_IDENTITY_STORE)); 4575 DTLS_IDENTITY_STORE));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698