Make UBSan warnings fatal and fix the existing ones

webrtc/modules/audio_processing/aecm/aecm_core_c.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/audio_processing/aecm/aecm_core.h"
 
 #include <stddef.h>
 #include <stdlib.h>
 
 extern "C" {
 #include "webrtc/common_audio/ring_buffer.h"
 #include "webrtc/common_audio/signal_processing/include/real_fft.h"
 }
 #include "webrtc/modules/audio_processing/aecm/echo_control_mobile.h"
 #include "webrtc/modules/audio_processing/utility/delay_estimator_wrapper.h"
 extern "C" {
 #include "webrtc/system_wrappers/include/cpu_features_wrapper.h"
 }
 
 #include "webrtc/rtc_base/checks.h"
+#include "webrtc/rtc_base/safe_conversions.h"
 #include "webrtc/typedefs.h"
 
 // Square root of Hanning window in Q14.
 static const ALIGN8_BEG int16_t WebRtcAecm_kSqrtHanning[] ALIGN8_END = {
   0, 399, 798, 1196, 1594, 1990, 2386, 2780, 3172,
   3562, 3951, 4337, 4720, 5101, 5478, 5853, 6224,
   6591, 6954, 7313, 7668, 8019, 8364, 8705, 9040,
   9370, 9695, 10013, 10326, 10633, 10933, 11227, 11514,
   11795, 12068, 12335, 12594, 12845, 13089, 13325, 13553,
   13773, 13985, 14189, 14384, 14571, 14749, 14918, 15079,
@@ skipping 408 matching lines @@
                            echoEst32);
   supGain = WebRtcAecm_CalcSuppressionGain(aecm);
 
 
   // Calculate Wiener filter hnl[]
   for (i = 0; i < PART_LEN1; i++)
   {
     // Far end signal through channel estimate in Q8
     // How much can we shift right to preserve resolution
     tmp32no1 = echoEst32[i] - aecm->echoFilt[i];
-    aecm->echoFilt[i] += (tmp32no1 * 50) >> 8;
+    aecm->echoFilt[i] += rtc::dchecked_cast<int32_t>(
+        (static_cast<int64_t>(tmp32no1) * 50) >> 8);

[kwiberg-webrtc, 2017/09/03 02:39:47]

If you write int64_t{x} instead of static_cast<int64_t>(x), the compiler will
complain unless all possible values of x are preserved.

[oprypin_webrtc, 2017/09/04 08:36:07]

OK thanks!

 
     zeros32 = WebRtcSpl_NormW32(aecm->echoFilt[i]) + 1;
     zeros16 = WebRtcSpl_NormW16(supGain) + 1;
     if (zeros32 + zeros16 > 16)
     {
       // Multiplication is safe
       // Result in
       // Q(RESOLUTION_CHANNEL+RESOLUTION_SUPGAIN+
       //   aecm->xfaQDomainBuf[diff])
       echoEst32Gained = WEBRTC_SPL_UMUL_32_16((uint32_t)aecm->echoFilt[i],
@@ skipping 294 matching lines @@
         13);
   }
   uImag[PART_LEN] = 0;
 
   for (i = 0; i < PART_LEN1; i++)
   {
     out[i].real = WebRtcSpl_AddSatW16(out[i].real, uReal[i]);
     out[i].imag = WebRtcSpl_AddSatW16(out[i].imag, uImag[i]);
   }
 }