 Chromium Code Reviews
 Chromium Code Reviews Issue 3004723002:
  Move RtpExtension to api/ directory and config.h/.cc to call/.  (Closed)
    
  
    Issue 3004723002:
  Move RtpExtension to api/ directory and config.h/.cc to call/.  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. | 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. | 
| 2 # | 2 # | 
| 3 # Use of this source code is governed by a BSD-style license | 3 # Use of this source code is governed by a BSD-style license | 
| 4 # that can be found in the LICENSE file in the root of the source | 4 # that can be found in the LICENSE file in the root of the source | 
| 5 # tree. An additional intellectual property rights grant can be found | 5 # tree. An additional intellectual property rights grant can be found | 
| 6 # in the file PATENTS. All contributing project authors may | 6 # in the file PATENTS. All contributing project authors may | 
| 7 # be found in the AUTHORS file in the root of the source tree. | 7 # be found in the AUTHORS file in the root of the source tree. | 
| 8 | 8 | 
| 9 import("../../webrtc.gni") | 9 import("../../webrtc.gni") | 
| 10 import("audio_coding.gni") | 10 import("audio_coding.gni") | 
| (...skipping 1371 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1382 "test/utility.cc", | 1382 "test/utility.cc", | 
| 1383 "test/utility.h", | 1383 "test/utility.h", | 
| 1384 ] | 1384 ] | 
| 1385 | 1385 | 
| 1386 deps = [ | 1386 deps = [ | 
| 1387 ":audio_coding", | 1387 ":audio_coding", | 
| 1388 ":audio_coding_module_typedefs", | 1388 ":audio_coding_module_typedefs", | 
| 1389 ":audio_format_conversion", | 1389 ":audio_format_conversion", | 
| 1390 "..:module_api", | 1390 "..:module_api", | 
| 1391 "../../:webrtc_common", | 1391 "../../:webrtc_common", | 
| 1392 "../../call:call", | |
| 
the sun
2017/08/31 07:08:04
why? I don't see any direct use of things defined
 
stefan-webrtc
2017/08/31 14:13:09
Thanks for catching.
 | |
| 1392 "../../rtc_base:rtc_base_approved", | 1393 "../../rtc_base:rtc_base_approved", | 
| 1393 "../../system_wrappers", | 1394 "../../system_wrappers", | 
| 1394 "../../system_wrappers:system_wrappers_default", | 1395 "../../system_wrappers:system_wrappers_default", | 
| 1395 "../../test:test_support", | 1396 "../../test:test_support", | 
| 1396 "../rtp_rtcp", | 1397 "../rtp_rtcp", | 
| 1397 "//testing/gtest", | 1398 "//testing/gtest", | 
| 1398 "//third_party/gflags:gflags", | 1399 "//third_party/gflags:gflags", | 
| 1399 ] | 1400 ] | 
| 1400 } # delay_test | 1401 } # delay_test | 
| 1401 | 1402 | 
| (...skipping 10 matching lines...) Expand all Loading... | |
| 1412 if (!build_with_chromium && is_clang) { | 1413 if (!build_with_chromium && is_clang) { | 
| 1413 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). | 1414 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). | 
| 1414 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] | 1415 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] | 
| 1415 } | 1416 } | 
| 1416 | 1417 | 
| 1417 deps = [ | 1418 deps = [ | 
| 1418 ":audio_coding", | 1419 ":audio_coding", | 
| 1419 ":audio_format_conversion", | 1420 ":audio_format_conversion", | 
| 1420 "..:module_api", | 1421 "..:module_api", | 
| 1421 "../../:webrtc_common", | 1422 "../../:webrtc_common", | 
| 1423 "../../call:call", | |
| 1422 "../../rtc_base:rtc_base_approved", | 1424 "../../rtc_base:rtc_base_approved", | 
| 1423 "../../system_wrappers", | 1425 "../../system_wrappers", | 
| 1424 "../../system_wrappers:system_wrappers_default", | 1426 "../../system_wrappers:system_wrappers_default", | 
| 1425 "../../test:test_support", | 1427 "../../test:test_support", | 
| 1426 "../rtp_rtcp", | 1428 "../rtp_rtcp", | 
| 1427 "//testing/gtest", | 1429 "//testing/gtest", | 
| 1428 "//third_party/gflags:gflags", | 1430 "//third_party/gflags:gflags", | 
| 1429 ] | 1431 ] | 
| 1430 } # insert_packet_with_timing | 1432 } # insert_packet_with_timing | 
| 1431 | 1433 | 
| (...skipping 27 matching lines...) Expand all Loading... | |
| 1459 | 1461 | 
| 1460 deps += audio_coding_deps | 1462 deps += audio_coding_deps | 
| 1461 deps += [ | 1463 deps += [ | 
| 1462 ":ilbc", | 1464 ":ilbc", | 
| 1463 ":isac", | 1465 ":isac", | 
| 1464 ":isac_fix", | 1466 ":isac_fix", | 
| 1465 ":neteq", | 1467 ":neteq", | 
| 1466 ":neteq_tools", | 1468 ":neteq_tools", | 
| 1467 "../../api/audio_codecs:audio_codecs_api", | 1469 "../../api/audio_codecs:audio_codecs_api", | 
| 1468 "../../api/audio_codecs/opus:audio_encoder_opus", | 1470 "../../api/audio_codecs/opus:audio_encoder_opus", | 
| 1471 "../../call:call", | |
| 1469 "../../common_audio", | 1472 "../../common_audio", | 
| 1470 "../../rtc_base:protobuf_utils", | 1473 "../../rtc_base:protobuf_utils", | 
| 1471 "../../test:test_main", | 1474 "../../test:test_main", | 
| 1472 "//testing/gtest", | 1475 "//testing/gtest", | 
| 1473 ] | 1476 ] | 
| 1474 | 1477 | 
| 1475 data = audio_decoder_unittests_resources | 1478 data = audio_decoder_unittests_resources | 
| 1476 | 1479 | 
| 1477 if (is_android) { | 1480 if (is_android) { | 
| 1478 deps += [ "//testing/android/native_test:native_test_native_code" ] | 1481 deps += [ "//testing/android/native_test:native_test_native_code" ] | 
| (...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1510 cflags = [ | 1513 cflags = [ | 
| 1511 # TODO(kjellander): bugs.webrtc.org/261: Fix this warning. | 1514 # TODO(kjellander): bugs.webrtc.org/261: Fix this warning. | 
| 1512 "/wd4373", # virtual function override. | 1515 "/wd4373", # virtual function override. | 
| 1513 ] | 1516 ] | 
| 1514 } | 1517 } | 
| 1515 | 1518 | 
| 1516 deps += [ | 1519 deps += [ | 
| 1517 ":neteq", | 1520 ":neteq", | 
| 1518 ":neteq_test_tools", | 1521 ":neteq_test_tools", | 
| 1519 "../..:webrtc_common", | 1522 "../..:webrtc_common", | 
| 1523 "../../call:call", | |
| 1520 "../../rtc_base:rtc_base_approved", | 1524 "../../rtc_base:rtc_base_approved", | 
| 1521 "../../system_wrappers:system_wrappers_default", | 1525 "../../system_wrappers:system_wrappers_default", | 
| 1522 "../../test:test_support", | 1526 "../../test:test_support", | 
| 1523 "//third_party/gflags", | 1527 "//third_party/gflags", | 
| 1524 ] | 1528 ] | 
| 1525 } | 1529 } | 
| 1526 } | 1530 } | 
| 1527 | 1531 | 
| 1528 audio_codec_speed_tests_resources = [ | 1532 audio_codec_speed_tests_resources = [ | 
| 1529 "//resources/audio_coding/music_stereo_48kHz.pcm", | 1533 "//resources/audio_coding/music_stereo_48kHz.pcm", | 
| (...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1565 } | 1569 } | 
| 1566 | 1570 | 
| 1567 if (is_ios) { | 1571 if (is_ios) { | 
| 1568 deps += [ ":audio_codec_speed_tests_data" ] | 1572 deps += [ ":audio_codec_speed_tests_data" ] | 
| 1569 } | 1573 } | 
| 1570 | 1574 | 
| 1571 deps += [ | 1575 deps += [ | 
| 1572 ":isac_fix", | 1576 ":isac_fix", | 
| 1573 ":webrtc_opus", | 1577 ":webrtc_opus", | 
| 1574 "../..:webrtc_common", | 1578 "../..:webrtc_common", | 
| 1579 "../../api:libjingle_peerconnection_api", | |
| 1580 "../../call:call", | |
| 1575 "../../rtc_base:rtc_base_approved", | 1581 "../../rtc_base:rtc_base_approved", | 
| 1582 "../../system_wrappers:metrics_default", | |
| 1576 "../../system_wrappers:system_wrappers_default", | 1583 "../../system_wrappers:system_wrappers_default", | 
| 1584 "../../test:field_trial", | |
| 1577 "../../test:test_main", | 1585 "../../test:test_main", | 
| 1578 "../audio_processing", | 1586 "../audio_processing", | 
| 1579 "//testing/gtest", | 1587 "//testing/gtest", | 
| 1580 ] | 1588 ] | 
| 1581 } | 1589 } | 
| 1582 | 1590 | 
| 1583 rtc_source_set("neteq_test_support") { | 1591 rtc_source_set("neteq_test_support") { | 
| 1584 testonly = true | 1592 testonly = true | 
| 1585 sources = [ | 1593 sources = [ | 
| 1586 "neteq/tools/neteq_external_decoder_test.cc", | 1594 "neteq/tools/neteq_external_decoder_test.cc", | 
| (...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1696 ":cng", | 1704 ":cng", | 
| 1697 ":g711", | 1705 ":g711", | 
| 1698 ":g722", | 1706 ":g722", | 
| 1699 ":ilbc", | 1707 ":ilbc", | 
| 1700 ":isac", | 1708 ":isac", | 
| 1701 ":neteq", | 1709 ":neteq", | 
| 1702 ":neteq_test_tools_deprecated", | 1710 ":neteq_test_tools_deprecated", | 
| 1703 ":pcm16b", | 1711 ":pcm16b", | 
| 1704 ":webrtc_opus", | 1712 ":webrtc_opus", | 
| 1705 "../..:webrtc_common", | 1713 "../..:webrtc_common", | 
| 1714 "../../api:libjingle_peerconnection_api", | |
| 
the sun
2017/08/31 07:08:04
...uhm, really?
 
stefan-webrtc
2017/08/31 14:13:09
I thought it was, but seems like it isn't any long
 | |
| 1715 "../../call:call", | |
| 1706 "../../common_audio", | 1716 "../../common_audio", | 
| 1707 "../../rtc_base:rtc_base_approved", | 1717 "../../rtc_base:rtc_base_approved", | 
| 1718 "../../system_wrappers:metrics_default", | |
| 1719 "../../test:field_trial", | |
| 1708 ] | 1720 ] | 
| 1709 | 1721 | 
| 1710 configs += [ ":RTPencode_config" ] | 1722 configs += [ ":RTPencode_config" ] | 
| 1711 | 1723 | 
| 1712 sources = [ | 1724 sources = [ | 
| 1713 "neteq/test/PayloadTypes.h", | 1725 "neteq/test/PayloadTypes.h", | 
| 1714 "neteq/test/RTPencode.cc", | 1726 "neteq/test/RTPencode.cc", | 
| 1715 ] | 1727 ] | 
| 1716 | 1728 | 
| 1717 include_dirs = [ | 1729 include_dirs = [ | 
| (...skipping 22 matching lines...) Expand all Loading... | |
| 1740 } | 1752 } | 
| 1741 | 1753 | 
| 1742 rtc_executable("rtpcat") { | 1754 rtc_executable("rtpcat") { | 
| 1743 testonly = true | 1755 testonly = true | 
| 1744 | 1756 | 
| 1745 sources = [ | 1757 sources = [ | 
| 1746 "neteq/tools/rtpcat.cc", | 1758 "neteq/tools/rtpcat.cc", | 
| 1747 ] | 1759 ] | 
| 1748 | 1760 | 
| 1749 deps = [ | 1761 deps = [ | 
| 1762 "../../call:call", | |
| 1750 "../../rtc_base:rtc_base_approved", | 1763 "../../rtc_base:rtc_base_approved", | 
| 1751 "../../system_wrappers:system_wrappers_default", | 1764 "../../system_wrappers:system_wrappers_default", | 
| 1752 "../../test:rtp_test_utils", | 1765 "../../test:rtp_test_utils", | 
| 1753 "//testing/gtest", | 1766 "//testing/gtest", | 
| 1754 ] | 1767 ] | 
| 1755 } | 1768 } | 
| 1756 | 1769 | 
| 1757 rtc_executable("RTPtimeshift") { | 1770 rtc_executable("RTPtimeshift") { | 
| 1758 testonly = true | 1771 testonly = true | 
| 1759 | 1772 | 
| (...skipping 25 matching lines...) Expand all Loading... | |
| 1785 testonly = true | 1798 testonly = true | 
| 1786 | 1799 | 
| 1787 sources = [ | 1800 sources = [ | 
| 1788 "neteq/tools/rtp_analyze.cc", | 1801 "neteq/tools/rtp_analyze.cc", | 
| 1789 ] | 1802 ] | 
| 1790 | 1803 | 
| 1791 deps = [ | 1804 deps = [ | 
| 1792 ":neteq", | 1805 ":neteq", | 
| 1793 ":neteq_test_tools", | 1806 ":neteq_test_tools", | 
| 1794 ":pcm16b", | 1807 ":pcm16b", | 
| 1808 "../../call:call", | |
| 1795 "../../system_wrappers:system_wrappers_default", | 1809 "../../system_wrappers:system_wrappers_default", | 
| 1796 "//testing/gtest", | 1810 "//testing/gtest", | 
| 1797 "//third_party/gflags:gflags", | 1811 "//third_party/gflags:gflags", | 
| 1798 ] | 1812 ] | 
| 1799 | 1813 | 
| 1800 if (!build_with_chromium && is_clang) { | 1814 if (!build_with_chromium && is_clang) { | 
| 1801 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). | 1815 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). | 
| 1802 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] | 1816 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] | 
| 1803 } | 1817 } | 
| 1804 } | 1818 } | 
| 1805 | 1819 | 
| 1806 rtc_executable("neteq_opus_quality_test") { | 1820 rtc_executable("neteq_opus_quality_test") { | 
| 1807 testonly = true | 1821 testonly = true | 
| 1808 | 1822 | 
| 1809 sources = [ | 1823 sources = [ | 
| 1810 "neteq/test/neteq_opus_quality_test.cc", | 1824 "neteq/test/neteq_opus_quality_test.cc", | 
| 1811 ] | 1825 ] | 
| 1812 | 1826 | 
| 1813 deps = [ | 1827 deps = [ | 
| 1814 ":neteq", | 1828 ":neteq", | 
| 1815 ":neteq_quality_test_support", | 1829 ":neteq_quality_test_support", | 
| 1816 ":neteq_tools", | 1830 ":neteq_tools", | 
| 1817 ":webrtc_opus", | 1831 ":webrtc_opus", | 
| 1832 "../../call:call", | |
| 1818 "../../rtc_base:rtc_base_approved", | 1833 "../../rtc_base:rtc_base_approved", | 
| 1819 "../../test:test_main", | 1834 "../../test:test_main", | 
| 1820 "//testing/gtest", | 1835 "//testing/gtest", | 
| 1821 ] | 1836 ] | 
| 1822 } | 1837 } | 
| 1823 | 1838 | 
| 1824 rtc_executable("neteq_speed_test") { | 1839 rtc_executable("neteq_speed_test") { | 
| 1825 testonly = true | 1840 testonly = true | 
| 1826 | 1841 | 
| 1827 sources = [ | 1842 sources = [ | 
| 1828 "neteq/test/neteq_speed_test.cc", | 1843 "neteq/test/neteq_speed_test.cc", | 
| 1829 ] | 1844 ] | 
| 1830 | 1845 | 
| 1831 deps = [ | 1846 deps = [ | 
| 1832 ":neteq", | 1847 ":neteq", | 
| 1833 ":neteq_test_support", | 1848 ":neteq_test_support", | 
| 1834 "../..:webrtc_common", | 1849 "../..:webrtc_common", | 
| 1850 "../../call:call", | |
| 1835 "../../system_wrappers:system_wrappers_default", | 1851 "../../system_wrappers:system_wrappers_default", | 
| 1836 "../../test:test_support", | 1852 "../../test:test_support", | 
| 1837 "//third_party/gflags", | 1853 "//third_party/gflags", | 
| 1838 ] | 1854 ] | 
| 1839 } | 1855 } | 
| 1840 | 1856 | 
| 1841 rtc_executable("neteq_ilbc_quality_test") { | 1857 rtc_executable("neteq_ilbc_quality_test") { | 
| 1842 testonly = true | 1858 testonly = true | 
| 1843 | 1859 | 
| 1844 sources = [ | 1860 sources = [ | 
| 1845 "neteq/test/neteq_ilbc_quality_test.cc", | 1861 "neteq/test/neteq_ilbc_quality_test.cc", | 
| 1846 ] | 1862 ] | 
| 1847 | 1863 | 
| 1848 deps = [ | 1864 deps = [ | 
| 1849 ":ilbc", | 1865 ":ilbc", | 
| 1850 ":neteq", | 1866 ":neteq", | 
| 1851 ":neteq_quality_test_support", | 1867 ":neteq_quality_test_support", | 
| 1852 ":neteq_tools", | 1868 ":neteq_tools", | 
| 1853 "../..:webrtc_common", | 1869 "../..:webrtc_common", | 
| 1870 "../../call:call", | |
| 1854 "../../rtc_base:rtc_base_approved", | 1871 "../../rtc_base:rtc_base_approved", | 
| 1855 "../../system_wrappers:system_wrappers_default", | 1872 "../../system_wrappers:system_wrappers_default", | 
| 1856 "../../test:test_main", | 1873 "../../test:test_main", | 
| 1857 "//testing/gtest", | 1874 "//testing/gtest", | 
| 1858 ] | 1875 ] | 
| 1859 } | 1876 } | 
| 1860 | 1877 | 
| 1861 rtc_executable("neteq_isac_quality_test") { | 1878 rtc_executable("neteq_isac_quality_test") { | 
| 1862 testonly = true | 1879 testonly = true | 
| 1863 | 1880 | 
| 1864 sources = [ | 1881 sources = [ | 
| 1865 "neteq/test/neteq_isac_quality_test.cc", | 1882 "neteq/test/neteq_isac_quality_test.cc", | 
| 1866 ] | 1883 ] | 
| 1867 | 1884 | 
| 1868 deps = [ | 1885 deps = [ | 
| 1869 ":isac_fix", | 1886 ":isac_fix", | 
| 1870 ":neteq", | 1887 ":neteq", | 
| 1871 ":neteq_quality_test_support", | 1888 ":neteq_quality_test_support", | 
| 1889 "../../call:call", | |
| 1872 "../../rtc_base:rtc_base_approved", | 1890 "../../rtc_base:rtc_base_approved", | 
| 1873 "../../test:test_main", | 1891 "../../test:test_main", | 
| 1874 "//testing/gtest", | 1892 "//testing/gtest", | 
| 1875 ] | 1893 ] | 
| 1876 } | 1894 } | 
| 1877 | 1895 | 
| 1878 rtc_executable("neteq_pcmu_quality_test") { | 1896 rtc_executable("neteq_pcmu_quality_test") { | 
| 1879 testonly = true | 1897 testonly = true | 
| 1880 | 1898 | 
| 1881 sources = [ | 1899 sources = [ | 
| 1882 "neteq/test/neteq_pcmu_quality_test.cc", | 1900 "neteq/test/neteq_pcmu_quality_test.cc", | 
| 1883 ] | 1901 ] | 
| 1884 | 1902 | 
| 1885 deps = [ | 1903 deps = [ | 
| 1886 ":g711", | 1904 ":g711", | 
| 1887 ":neteq", | 1905 ":neteq", | 
| 1888 ":neteq_quality_test_support", | 1906 ":neteq_quality_test_support", | 
| 1907 "../../call:call", | |
| 1889 "../../rtc_base:rtc_base_approved", | 1908 "../../rtc_base:rtc_base_approved", | 
| 1890 "../../test:test_main", | 1909 "../../test:test_main", | 
| 1891 "//testing/gtest", | 1910 "//testing/gtest", | 
| 1892 ] | 1911 ] | 
| 1893 } | 1912 } | 
| 1894 | 1913 | 
| 1895 rtc_executable("isac_fix_test") { | 1914 rtc_executable("isac_fix_test") { | 
| 1896 testonly = true | 1915 testonly = true | 
| 1897 | 1916 | 
| 1898 sources = [ | 1917 sources = [ | 
| (...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2030 | 2049 | 
| 2031 rtc_executable("webrtc_opus_fec_test") { | 2050 rtc_executable("webrtc_opus_fec_test") { | 
| 2032 testonly = true | 2051 testonly = true | 
| 2033 | 2052 | 
| 2034 sources = [ | 2053 sources = [ | 
| 2035 "codecs/opus/opus_fec_test.cc", | 2054 "codecs/opus/opus_fec_test.cc", | 
| 2036 ] | 2055 ] | 
| 2037 | 2056 | 
| 2038 deps = [ | 2057 deps = [ | 
| 2039 ":webrtc_opus", | 2058 ":webrtc_opus", | 
| 2059 "../../call:call", | |
| 2040 "../../common_audio", | 2060 "../../common_audio", | 
| 2041 "../../rtc_base:rtc_base_approved", | 2061 "../../rtc_base:rtc_base_approved", | 
| 2042 "../../test:test_main", | 2062 "../../test:test_main", | 
| 2043 "//testing/gtest", | 2063 "//testing/gtest", | 
| 2044 ] | 2064 ] | 
| 2045 | 2065 | 
| 2046 if (!build_with_chromium && is_clang) { | 2066 if (!build_with_chromium && is_clang) { | 
| 2047 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). | 2067 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). | 
| 2048 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] | 2068 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] | 
| 2049 } | 2069 } | 
| (...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2234 # webrtc/api/audio_codecs:builtin_audio_decoder_factory instead. | 2254 # webrtc/api/audio_codecs:builtin_audio_decoder_factory instead. | 
| 2235 # TODO(ossu): Remove this. | 2255 # TODO(ossu): Remove this. | 
| 2236 rtc_source_set("builtin_audio_encoder_factory") { | 2256 rtc_source_set("builtin_audio_encoder_factory") { | 
| 2237 sources = [ | 2257 sources = [ | 
| 2238 "codecs/builtin_audio_encoder_factory.h", | 2258 "codecs/builtin_audio_encoder_factory.h", | 
| 2239 ] | 2259 ] | 
| 2240 deps = [ | 2260 deps = [ | 
| 2241 "../../api/audio_codecs:builtin_audio_encoder_factory", | 2261 "../../api/audio_codecs:builtin_audio_encoder_factory", | 
| 2242 ] | 2262 ] | 
| 2243 } | 2263 } | 
| OLD | NEW |