Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: webrtc/video/full_stack_tests.cc

Issue 3003823003: Fix FrameConfigs used for VP8 with four temporal layers. (Closed)
Patch Set: Fixed int to uint cast in test Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/include/vp8_common_types.h ('k') | webrtc/video/replay.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/full_stack_tests.cc
diff --git a/webrtc/video/full_stack_tests.cc b/webrtc/video/full_stack_tests.cc
index 8190bf6cb5290394d89640c1185d2a46b6148817..9b62001121b33ca3dda9d21b8f4eff020080fbc3 100644
--- a/webrtc/video/full_stack_tests.cc
+++ b/webrtc/video/full_stack_tests.cc
@@ -304,6 +304,7 @@ TEST_F(FullStackTest, ForemanCif1000kbps100msLimitedQueue) {
RunTest(foreman_cif);
}
+// TODO(sprang): Remove this if we have the similar ModerateLimits below?
TEST_F(FullStackTest, ConferenceMotionHd2000kbps100msLimitedQueue) {
VideoQualityTest::Params conf_motion_hd;
conf_motion_hd.call.send_side_bwe = true;
@@ -319,6 +320,87 @@ TEST_F(FullStackTest, ConferenceMotionHd2000kbps100msLimitedQueue) {
RunTest(conf_motion_hd);
}
+TEST_F(FullStackTest, ConferenceMotionHd1TLModerateLimits) {
+ VideoQualityTest::Params conf_motion_hd;
+ conf_motion_hd.call.send_side_bwe = true;
+ conf_motion_hd.video = {
+ true, 1280, 720, 50, 30000,
+ 3000000, 3000000, false, "VP8", 1,
+ -1, 0, false, false, "ConferenceMotion_1280_720_50"};
+ conf_motion_hd.analyzer = {"conference_motion_hd_1tl_moderate_limits", 0.0,
+ 0.0, kFullStackTestDurationSecs};
+ conf_motion_hd.pipe.queue_length_packets = 50;
+ conf_motion_hd.pipe.loss_percent = 3;
+ conf_motion_hd.pipe.queue_delay_ms = 100;
+ conf_motion_hd.pipe.link_capacity_kbps = 2000;
+ RunTest(conf_motion_hd);
+}
+
+TEST_F(FullStackTest, ConferenceMotionHd2TLModerateLimits) {
+ VideoQualityTest::Params conf_motion_hd;
+ conf_motion_hd.call.send_side_bwe = true;
+ conf_motion_hd.video = {
+ true, 1280, 720, 50, 30000,
+ 3000000, 3000000, false, "VP8", 2,
+ -1, 0, false, false, "ConferenceMotion_1280_720_50"};
+ conf_motion_hd.analyzer = {"conference_motion_hd_2tl_moderate_limits", 0.0,
+ 0.0, kFullStackTestDurationSecs};
+ conf_motion_hd.pipe.queue_length_packets = 50;
+ conf_motion_hd.pipe.loss_percent = 3;
+ conf_motion_hd.pipe.queue_delay_ms = 100;
+ conf_motion_hd.pipe.link_capacity_kbps = 2000;
+ RunTest(conf_motion_hd);
+}
+
+TEST_F(FullStackTest, ConferenceMotionHd3TLModerateLimits) {
+ VideoQualityTest::Params conf_motion_hd;
+ conf_motion_hd.call.send_side_bwe = true;
+ conf_motion_hd.video = {
+ true, 1280, 720, 50, 30000,
+ 3000000, 3000000, false, "VP8", 3,
+ -1, 0, false, false, "ConferenceMotion_1280_720_50"};
+ conf_motion_hd.analyzer = {"conference_motion_hd_3tl_moderate_limits", 0.0,
+ 0.0, kFullStackTestDurationSecs};
+ conf_motion_hd.pipe.queue_length_packets = 50;
+ conf_motion_hd.pipe.loss_percent = 3;
+ conf_motion_hd.pipe.queue_delay_ms = 100;
+ conf_motion_hd.pipe.link_capacity_kbps = 2000;
+ RunTest(conf_motion_hd);
+}
+
+TEST_F(FullStackTest, ConferenceMotionHd4TLModerateLimits) {
+ VideoQualityTest::Params conf_motion_hd;
+ conf_motion_hd.call.send_side_bwe = true;
+ conf_motion_hd.video = {
+ true, 1280, 720, 50, 30000,
+ 3000000, 3000000, false, "VP8", 4,
+ -1, 0, false, false, "ConferenceMotion_1280_720_50"};
+ conf_motion_hd.analyzer = {"conference_motion_hd_4tl_moderate_limits", 0.0,
+ 0.0, kFullStackTestDurationSecs};
+ conf_motion_hd.pipe.queue_length_packets = 50;
+ conf_motion_hd.pipe.loss_percent = 3;
+ conf_motion_hd.pipe.queue_delay_ms = 100;
+ conf_motion_hd.pipe.link_capacity_kbps = 2000;
+ RunTest(conf_motion_hd);
+}
+
+TEST_F(FullStackTest, ConferenceMotionHd3TLModerateLimitsAltTLPattern) {
+ test::ScopedFieldTrials field_trial("WebRTC-UseShortVP8TL3Pattern/Enabled/");
+ VideoQualityTest::Params conf_motion_hd;
+ conf_motion_hd.call.send_side_bwe = true;
+ conf_motion_hd.video = {
+ true, 1280, 720, 50, 30000,
+ 3000000, 3000000, false, "VP8", 3,
+ -1, 0, false, false, "ConferenceMotion_1280_720_50"};
+ conf_motion_hd.analyzer = {"conference_motion_hd_3tl_alt_moderate_limits",
+ 0.0, 0.0, kFullStackTestDurationSecs};
+ conf_motion_hd.pipe.queue_length_packets = 50;
+ conf_motion_hd.pipe.loss_percent = 3;
+ conf_motion_hd.pipe.queue_delay_ms = 100;
+ conf_motion_hd.pipe.link_capacity_kbps = 2000;
+ RunTest(conf_motion_hd);
+}
+
#if !defined(RTC_DISABLE_VP9)
TEST_F(FullStackTest, ConferenceMotionHd2000kbps100msLimitedQueueVP9) {
VideoQualityTest::Params conf_motion_hd;
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/include/vp8_common_types.h ('k') | webrtc/video/replay.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698