Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 3003733002: Utilizing the AEC3 config struct for constants. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index 0a0951791abc623dd2932a5f54011a2e9d1cbfb5..b5dc85ee906d68af6a6337687e45a65272f7c608 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -267,6 +267,49 @@ class AudioProcessing : public rtc::RefCountInterface {
// The functionality is not yet activated in the code and turning this on
// does not yet have the desired behavior.
struct EchoCanceller3 {
+ struct Param {
+ struct Erle {
+ float min = 1.f;
+ float max_l = 8.f;
+ float max_h = 1.5f;
+ } erle;
+
+ struct EpStrength {
+ float lf = 100.f;
+ float mf = 1000.f;
+ float hf = 5000.f;
+ float default_len = 0.8f;
+ } ep_strength;
+
+ struct Mask {
+ float m1 = 0.01f;
+ float m2 = 0.001f;
+ float m3 = 0.01f;
+ float m4 = 0.1f;
+ } gain_mask;
+
+ struct Thresholds {
hlundin-webrtc 2017/08/23 14:52:22 A little too generic. Threshold for what?
peah-webrtc 2017/08/24 07:00:52 I agree. A changed the naming a bit. PTAL
+ float min_echo1 = 192.f;
+ float min_echo2 = 64.f;
+ } thresholds;
+
+ struct GainUpdates {
+ struct GainChanges {
+ float max_inc;
+ float max_dec;
+ float rate_inc;
+ float rate_dec;
+ float min_inc;
+ float min_dec;
+ };
+
+ GainChanges low_noise = {8.f, 8.f, 2.f, 2.f, 4.f, 4.f};
+ GainChanges normal = {4.f, 4.f, 2.f, 2.f, 1.2f, 2.f};
+ GainChanges saturation = {1.2f, 1.2f, 1.5f, 1.5f, 1.f, 1.f};
+
+ float floor_first_increase = 0.001f;
+ } gain_updates;
+ } param;
bool enabled = false;
} echo_canceller3;

Powered by Google App Engine
This is Rietveld 408576698