pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart - Issue 3003613002: improve DDC's type checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

Issue 3003613002: improve DDC's type checks (Closed)

Patch Set: format Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/dev_compiler/lib/src/compiler/code_generator.dart ('K') | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart » ('j') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

index 63c2e11c3f149a5628032f851c7f87795a2c339b..4969414d0cf1f492adda22121bb6b4da7f6ea83a 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

@@ -185,7 +185,9 @@ final _AsyncStarStreamController = JS(

// that we should schedule `await` in `async*` the same as in `async`.

this.isWaiting = true;

let future = iter.value;

- if (!$instanceOf(future, ${getGenericClass(Future)})) {

+ // TODO(jmesserly): `async` uses a different check that looks for the

+ // (private) implementation type of `Future`, rather than the public type.

+ if (!$Future.is(future)) {

future = $Future.value(future);

}

return future.then($dynamic)((x) => this.runBody(x),