Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: webrtc/call/rtp_demuxer_unittest.cc

Issue 3003133002: Fix an implicit narrowing conversion found by MSVC (Closed)
Patch Set: with roll Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/rtp_demuxer_unittest.cc
diff --git a/webrtc/call/rtp_demuxer_unittest.cc b/webrtc/call/rtp_demuxer_unittest.cc
index 39dc67b0a17b7ef20f726a6ff699238a280403ac..17c0b0c1268ed738451d5898af68d0e539f37261 100644
--- a/webrtc/call/rtp_demuxer_unittest.cc
+++ b/webrtc/call/rtp_demuxer_unittest.cc
@@ -346,7 +346,8 @@ TEST_F(RtpDemuxerTest, OnRtpPacketCalledOnCorrectSinkByRsid) {
}
for (size_t i = 0; i < arraysize(rsids); i++) {
- auto packet = CreatePacketWithSsrcRsid(i, rsids[i]);
+ auto packet = CreatePacketWithSsrcRsid(rtc::dchecked_cast<uint32_t>(i),
kwiberg-webrtc 2017/08/22 20:06:05 There's almost never a reason to use DCHECK instea
oprypin_webrtc 2017/08/22 20:28:39 Done.
+ rsids[i]);
EXPECT_CALL(sinks[i], OnRtpPacket(SamePacketAs(*packet))).Times(1);
EXPECT_TRUE(demuxer_.OnRtpPacket(*packet));
}
@@ -360,7 +361,8 @@ TEST_F(RtpDemuxerTest, OnRtpPacketCalledOnCorrectSinkByMid) {
}
for (size_t i = 0; i < arraysize(mids); i++) {
- auto packet = CreatePacketWithSsrcMid(i, mids[i]);
+ auto packet = CreatePacketWithSsrcMid(rtc::dchecked_cast<uint32_t>(i),
+ mids[i]);
EXPECT_CALL(sinks[i], OnRtpPacket(SamePacketAs(*packet))).Times(1);
EXPECT_TRUE(demuxer_.OnRtpPacket(*packet));
}
@@ -414,7 +416,7 @@ TEST_F(RtpDemuxerTest, PacketsDeliveredInRightOrder) {
std::unique_ptr<RtpPacketReceived> packets[5];
for (size_t i = 0; i < arraysize(packets); i++) {
packets[i] = CreatePacketWithSsrc(ssrc);
- packets[i]->SetSequenceNumber(i);
+ packets[i]->SetSequenceNumber(rtc::dchecked_cast<uint16_t>(i));
}
InSequence sequence;

Powered by Google App Engine
This is Rietveld 408576698