[pinpoint] Refactor Quest Generator.

dashboard/dashboard/pinpoint/handlers/quest_generator_test.py

Index: dashboard/dashboard/pinpoint/handlers/quest_generator_test.py
diff --git a/dashboard/dashboard/pinpoint/handlers/quest_generator_test.py b/dashboard/dashboard/pinpoint/handlers/quest_generator_test.py
new file mode 100644
index 0000000000000000000000000000000000000000..1aede9becbf4605a016435a37b39cd7a2bcf4850
--- /dev/null
+++ b/dashboard/dashboard/pinpoint/handlers/quest_generator_test.py
@@ -0,0 +1,151 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import unittest
+
+from dashboard.pinpoint.handlers import quest_generator
+from dashboard.pinpoint.models import quest
+
+
+_MIN_RUN_TEST_ARGUMENTS = [
+    'speedometer', '--pageset-repeat', '20', '--browser', 'release',
+    '-v', '--upload-results', '--output-format', 'chartjson',
+    '--isolated-script-test-output', '${ISOLATED_OUTDIR}/output.json',
+    '--isolated-script-test-chartjson-output',
+    '${ISOLATED_OUTDIR}/chartjson-output.json',
+]
+
+
+_ALL_RUN_TEST_ARGUMENTS = [
+    'speedometer', '--story-filter', 'http://www.fifa.com/',
+    '--pageset-repeat', '50', '--browser', 'release',
+    '-v', '--upload-results', '--output-format', 'chartjson',
+    '--isolated-script-test-output', '${ISOLATED_OUTDIR}/output.json',
+    '--isolated-script-test-chartjson-output',
+    '${ISOLATED_OUTDIR}/chartjson-output.json',
+]
+
+
+class FindIsolateTest(unittest.TestCase):
+
+  def testMissingArguments(self):
+    arguments = {'target': 'telemetry_perf_tests'}
+    # configuration is missing.
+    with self.assertRaises(TypeError):
+      quest_generator.GenerateQuests(arguments)
+
+    arguments = {'configuration': 'chromium-rel-mac11-pro'}
+    # target is missing.
+    with self.assertRaises(TypeError):
+      quest_generator.GenerateQuests(arguments)
+
+  def testAllArguments(self):
+    arguments = {
+        'configuration': 'chromium-rel-mac11-pro',
+        'target': 'telemetry_perf_tests',
+    }
+    expected_quests = [
+        quest.FindIsolate('chromium-rel-mac11-pro', 'telemetry_perf_tests'),
+    ]
+    self.assertEqual(quest_generator.GenerateQuests(arguments),
+                     (arguments, expected_quests))
+
+
+class TelemetryRunTestQuest(unittest.TestCase):
+
+  def testMissingArguments(self):
+    arguments = {
+        'configuration': 'chromium-rel-mac11-pro',
+        'target': 'telemetry_perf_tests',
+        'dimensions': '{}',
+        # benchmark is missing.
+        'browser': 'release',
+    }
+    with self.assertRaises(TypeError):
+      quest_generator.GenerateQuests(arguments)
+
+    arguments = {
+        'configuration': 'chromium-rel-mac11-pro',
+        'target': 'telemetry_perf_tests',
+        'dimensions': '{}',
+        'benchmark': 'speedometer',
+        # browser is missing.
+    }
+    with self.assertRaises(TypeError):
+      quest_generator.GenerateQuests(arguments)
+
+  def testMinimumArguments(self):
+    arguments = {
+        'configuration': 'chromium-rel-mac11-pro',
+        'target': 'telemetry_perf_tests',
+        'dimensions': '{}',
+        'benchmark': 'speedometer',
+        'browser': 'release',
+    }
+
+    expected_quests = [
+        quest.FindIsolate('chromium-rel-mac11-pro', 'telemetry_perf_tests'),
+        quest.RunTest({}, _MIN_RUN_TEST_ARGUMENTS),
+    ]
+    self.assertEqual(quest_generator.GenerateQuests(arguments),
+                     (arguments, expected_quests))
+
+  def testAllArguments(self):
+    arguments = {
+        'configuration': 'chromium-rel-mac11-pro',
+        'target': 'telemetry_perf_tests',
+        'dimensions': '{"key": "value"}',
+        'benchmark': 'speedometer',
+        'browser': 'release',
+        'story': 'http://www.fifa.com/',
+        'repeat_count': '50',
+    }
+
+    expected_quests = [
+        quest.FindIsolate('chromium-rel-mac11-pro', 'telemetry_perf_tests'),
+        quest.RunTest({'key': 'value'}, _ALL_RUN_TEST_ARGUMENTS),
+    ]
+    self.assertEqual(quest_generator.GenerateQuests(arguments),
+                     (arguments, expected_quests))
+
+
+class ReadChartJsonValueQuest(unittest.TestCase):
+
+  def testMinimumArguments(self):
+    arguments = {
+        'configuration': 'chromium-rel-mac11-pro',
+        'target': 'telemetry_perf_tests',
+        'dimensions': '{}',
+        'benchmark': 'speedometer',
+        'browser': 'release',
+        'metric': 'pcv1-cold@@timeToFirst',
+    }
+
+    expected_quests = [
+        quest.FindIsolate('chromium-rel-mac11-pro', 'telemetry_perf_tests'),
+        quest.RunTest({}, _MIN_RUN_TEST_ARGUMENTS),
+        quest.ReadChartJsonValue('pcv1-cold@@timeToFirst', None),
+    ]
+    self.assertEqual(quest_generator.GenerateQuests(arguments),
+                     (arguments, expected_quests))
+
+  def testAllArguments(self):
+    arguments = {
+        'configuration': 'chromium-rel-mac11-pro',
+        'target': 'telemetry_perf_tests',
+        'dimensions': '{"key": "value"}',
+        'benchmark': 'speedometer',
+        'browser': 'release',
+        'story': 'http://www.fifa.com/',
+        'repeat_count': '50',
+        'metric': 'pcv1-cold@@timeTo',
+    }
+
+    expected_quests = [
+        quest.FindIsolate('chromium-rel-mac11-pro', 'telemetry_perf_tests'),
+        quest.RunTest({'key': 'value'}, _ALL_RUN_TEST_ARGUMENTS),
+        quest.ReadChartJsonValue('pcv1-cold@@timeTo', 'http://www.fifa.com/'),
+    ]
+    self.assertEqual(quest_generator.GenerateQuests(arguments),
+                     (arguments, expected_quests))