Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: webrtc/BUILD.gn

Issue 3002663002: Make it possible for tests to set up trace event handlers. (Closed)
Patch Set: Actually fix it. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/rtc_base/trace_event.h » ('j') | webrtc/rtc_base/trace_event.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index 54a7c1ca56ed79e3c9fd0c619cf5c538e597de26..e69903ac412333a306e7b84a7aff5a29d1f825c7 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -26,6 +26,9 @@ config("common_inherited_config") {
if (build_with_mozilla) {
defines += [ "WEBRTC_MOZILLA_BUILD" ]
}
+ if (rtc_include_tests) {
+ defines += [ "WEBRTC_NON_CONST_TRACE_EVENT_HANDLERS" ]
kjellander_webrtc 2017/08/16 12:17:14 Please add a comment explaining why this is needed
kwiberg-webrtc 2017/08/16 13:11:40 Please consider always defining this (to 0 or 1, f
ehmaldonado_webrtc 2017/08/16 13:40:57 Done.
+ }
if (build_with_chromium) {
defines = [
# TODO(kjellander): Cleanup unused ones and move defines closer to
« no previous file with comments | « no previous file | webrtc/rtc_base/trace_event.h » ('j') | webrtc/rtc_base/trace_event.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698