Implement move constructor for RTPFragmentationHeader.

webrtc/modules/include/module_common_types.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 73 matching lines @@
 
 class RTPFragmentationHeader {
  public:
   RTPFragmentationHeader()
       : fragmentationVectorSize(0),
         fragmentationOffset(NULL),
         fragmentationLength(NULL),
         fragmentationTimeDiff(NULL),
         fragmentationPlType(NULL) {}
 
+  RTPFragmentationHeader(RTPFragmentationHeader&& other)
+      : RTPFragmentationHeader() {
+    swap(other);
+  }
+
   ~RTPFragmentationHeader() {
     delete[] fragmentationOffset;
     delete[] fragmentationLength;
     delete[] fragmentationTimeDiff;
     delete[] fragmentationPlType;
   }
 
+  void operator=(RTPFragmentationHeader&& other) { swap(other); }
+
   void CopyFrom(const RTPFragmentationHeader& src) {
     if (this == &src) {
       return;
     }
 
     if (src.fragmentationVectorSize != fragmentationVectorSize) {
       // new size of vectors
 
       // delete old
       delete[] fragmentationOffset;
@@ skipping 98 matching lines @@
   uint16_t fragmentationVectorSize;  // Number of fragmentations
   size_t* fragmentationOffset;       // Offset of pointer to data for each
                                      // fragmentation
   size_t* fragmentationLength;       // Data size for each fragmentation
   uint16_t* fragmentationTimeDiff;   // Timestamp difference relative "now" for
                                      // each fragmentation
   uint8_t* fragmentationPlType;      // Payload type of each fragmentation
 
  private:
   RTC_DISALLOW_COPY_AND_ASSIGN(RTPFragmentationHeader);
+
+  void swap(RTPFragmentationHeader& other) {
+    std::swap(fragmentationVectorSize, other.fragmentationVectorSize);
+    std::swap(fragmentationOffset, other.fragmentationOffset);
+    std::swap(fragmentationLength, other.fragmentationLength);
+    std::swap(fragmentationTimeDiff, other.fragmentationTimeDiff);
+    std::swap(fragmentationPlType, other.fragmentationPlType);
+  }

[kwiberg-webrtc, 2017/08/28 08:36:20]

To make this useful with the standard swapping idiom (see
http://en.cppreference.com/w/cpp/concept/Swappable)---and to use this idiom for
the member swap calls---define swap() like this in the public section of the
class:

  friend void swap(RTPFragmentationHeader&a, RTPFragmentationHeader&b) {
    using std::swap;
    swap(a.fragmentationVectorSize, b.fragmentationVectorSize);
    // ... and the rest of the members ...
  }

[sakal, 2017/08/28 09:29:27]

Done.

 };
 
 struct RTCPVoIPMetric {
   // RFC 3611 4.7
   uint8_t lossRate;
   uint8_t discardRate;
   uint8_t burstDensity;
   uint8_t gapDensity;
   uint16_t burstDuration;
   uint16_t gapDuration;
@@ skipping 393 matching lines @@
   static constexpr int kNotAProbe = -1;
   int send_bitrate_bps = -1;
   int probe_cluster_id = kNotAProbe;
   int probe_cluster_min_probes = -1;
   int probe_cluster_min_bytes = -1;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_INCLUDE_MODULE_COMMON_TYPES_H_