Decoupling rtc_base from Obj-C code

webrtc/rtc_base/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/crypto.gni")
 import("//build/config/ui.gni")
@@ skipping 381 matching lines @@
   } else {
     include_dirs = [ "$rtc_jsoncpp_root" ]
 
     # When defined changes the include path for json.h to where it is
     # expected to be when building json outside of the standalone build.
     defines += [ "WEBRTC_EXTERNAL_JSON" ]
   }
 }
 
 rtc_static_library("rtc_base") {
+  if (is_ios || is_mac) {
+    sources = [
+      "noop.mm",
+    ]
+    public_deps = [
+      ":objc_rtc_base",
+    ]
+  } else {
+    sources = [
+      "noop.cc",
+    ]
+    public_deps = [
+      ":rtc_base_generic",
+    ]
+  }
+}
+
+rtc_static_library("objc_rtc_base") {

[kjellander_webrtc, 2017/08/14 14:00:36]

How about rtc_base_objc?

[mbonadei, 2017/08/14 15:07:34]

Seems good to me. I also prefer the _objc suffix (I will update all the other
CLs in the next days).

+  sources = [
+    "applefilesystem.mm",
+    "thread_darwin.mm",
+  ]
+  public_deps = [
+    ":rtc_base_generic",
+  ]
+  visibility = [ ":rtc_base" ]
+}
+
+rtc_static_library("rtc_base_generic") {
   cflags = []
   cflags_cc = []
   libs = []
   defines = []
   deps = [
     "..:webrtc_common",
   ]
   public_deps = [
     ":rtc_base_approved",
   ]
   public_configs = []
 
   all_dependent_configs = [ ":rtc_base_all_dependent_config" ]
 
   sources = [
-    "applefilesystem.mm",
     "asyncinvoker-inl.h",
     "asyncinvoker.cc",
     "asyncinvoker.h",
     "asyncpacketsocket.cc",
     "asyncpacketsocket.h",
     "asyncresolverinterface.cc",
     "asyncresolverinterface.h",
     "asyncsocket.cc",
     "asyncsocket.h",
     "asynctcpsocket.cc",
@@ skipping 73 matching lines @@
     "sslidentity.cc",
     "sslidentity.h",
     "sslstreamadapter.cc",
     "sslstreamadapter.h",
     "stream.cc",
     "stream.h",
     "thread.cc",
     "thread.h",
   ]
 
+  visibility = [

[kjellander_webrtc, 2017/08/14 14:00:36]

How about 
visibility = [ ":*" ]
to make maintenance a little easier.
Then move it up a few steps to make it consistent with most other targets.

[mbonadei, 2017/08/14 15:07:34]

I would like to keep it as private as possible because this is the real rtc_base
and I would like to avoid that a target depends on this one skipping the
proxy.

[kjellander_webrtc, 2017/08/15 08:40:58]

Fair enough.

+    ":rtc_base",
+    ":objc_rtc_base",
+  ]
+
   # TODO(henrike): issue 3307, make rtc_base build with the Chromium default
   # compiler settings.
   suppressed_configs += [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
   if (!is_win) {
     cflags += [ "-Wno-uninitialized" ]
   }
 
   if (build_with_chromium) {
     if (is_win) {
@@ skipping 39 matching lines @@
       "ifaddrs-android.h",
     ]
 
     libs += [
       "log",
       "GLESv2",
     ]
   }
 
   if (is_ios || is_mac) {
-    sources += [
-      "macifaddrs_converter.cc",
-      "thread_darwin.mm",
-    ]
+    sources += [ "macifaddrs_converter.cc" ]
   }
 
   if (use_x11) {
     libs += [
       "dl",
       "rt",
       "Xext",
       "X11",
       "Xcomposite",
       "Xrender",
@@ skipping 447 matching lines @@
 if (is_android) {
   android_library("base_java") {
     java_files = [
       "java/src/org/webrtc/ContextUtils.java",
       "java/src/org/webrtc/Logging.java",
       "java/src/org/webrtc/Size.java",
       "java/src/org/webrtc/ThreadUtils.java",
     ]
   }
 }