webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm - Issue 3001183002: Make a friendlier RTCVideoCodecInfo initializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm

Issue 3001183002: Make a friendlier RTCVideoCodecInfo initializer. (Closed)

Patch Set: Rebase Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec+Private.h ('k') | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm b/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm

index 3b03bf4e632d125c95ce9937d114c7867a4944d0..341363e942c5710b80d9a3c36a71a9a831968b94 100644

--- a/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm

+++ b/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm

@@ -58,9 +58,7 @@ bool IsHighProfileEnabled() {

@"packetization-mode" : @"1",

};

RTCVideoCodecInfo *constrainedHighInfo =

- [[RTCVideoCodecInfo alloc] initWithPayload:0

- name:codecName

- parameters:constrainedHighParams];

+ [[RTCVideoCodecInfo alloc] initWithName:codecName parameters:constrainedHighParams];

[codecs addObject:constrainedHighInfo];

}

@@ -70,9 +68,7 @@ bool IsHighProfileEnabled() {

@"packetization-mode" : @"1",

};

RTCVideoCodecInfo *constrainedBaselineInfo =

- [[RTCVideoCodecInfo alloc] initWithPayload:0

- name:codecName

- parameters:constrainedBaselineParams];

+ [[RTCVideoCodecInfo alloc] initWithName:codecName parameters:constrainedBaselineParams];

[codecs addObject:constrainedBaselineInfo];

return [codecs copy];

@@ -93,7 +89,7 @@ bool IsHighProfileEnabled() {

- (NSArray<RTCVideoCodecInfo *> *)supportedCodecs {

NSString *codecName = [NSString stringWithUTF8String:cricket::kH264CodecName];

- return @[ [[RTCVideoCodecInfo alloc] initWithPayload:0 name:codecName parameters:@{}] ];

+ return @[ [[RTCVideoCodecInfo alloc] initWithName:codecName parameters:nil] ];

}

@end