Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm

Issue 3001183002: Make a friendlier RTCVideoCodecInfo initializer. (Closed)
Patch Set: Mark -init as unavailable. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 14 matching lines...) Expand all
25 parameters:(NSDictionary<NSString *, NSString *> *)paramete rs { 25 parameters:(NSDictionary<NSString *, NSString *> *)paramete rs {
26 if (self = [super init]) { 26 if (self = [super init]) {
27 _payload = payload; 27 _payload = payload;
28 _name = name; 28 _name = name;
29 _parameters = parameters; 29 _parameters = parameters;
30 } 30 }
31 31
32 return self; 32 return self;
33 } 33 }
34 34
35 - (instancetype)initWithName:(NSString *)name
36 parameters:(nullable NSDictionary<NSString *, NSString *> *)pa rameters {
37 return [self initWithPayload:0 name:name parameters:(parameters ? parameters : @{})];
38 }
39
35 - (instancetype)initWithNativeVideoCodec:(cricket::VideoCodec)videoCodec { 40 - (instancetype)initWithNativeVideoCodec:(cricket::VideoCodec)videoCodec {
36 NSMutableDictionary *params = [NSMutableDictionary dictionary]; 41 NSMutableDictionary *params = [NSMutableDictionary dictionary];
37 for (auto it = videoCodec.params.begin(); it != videoCodec.params.end(); ++it) { 42 for (auto it = videoCodec.params.begin(); it != videoCodec.params.end(); ++it) {
38 [params setObject:[NSString stringForStdString:it->second] 43 [params setObject:[NSString stringForStdString:it->second]
39 forKey:[NSString stringForStdString:it->first]]; 44 forKey:[NSString stringForStdString:it->first]];
40 } 45 }
41 return [self initWithPayload:videoCodec.id 46 return [self initWithPayload:videoCodec.id
42 name:[NSString stringForStdString:videoCodec.name] 47 name:[NSString stringForStdString:videoCodec.name]
43 parameters:params]; 48 parameters:params];
44 } 49 }
(...skipping 17 matching lines...) Expand all
62 67
63 - (instancetype)initWithThresholdsLow:(NSInteger)low high:(NSInteger)high { 68 - (instancetype)initWithThresholdsLow:(NSInteger)low high:(NSInteger)high {
64 if (self = [super init]) { 69 if (self = [super init]) {
65 _low = low; 70 _low = low;
66 _high = high; 71 _high = high;
67 } 72 }
68 return self; 73 return self;
69 } 74 }
70 75
71 @end 76 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698