Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: webrtc/call/rtp_transport_controller_send.h

Issue 3000773002: Move PacedSender ownership to RtpTransportControllerSend. (Closed)
Patch Set: Fix test bug. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/call/fake_rtp_transport_controller_send.h ('k') | webrtc/call/rtp_transport_controller_send.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/rtp_transport_controller_send.h
diff --git a/webrtc/call/rtp_transport_controller_send.h b/webrtc/call/rtp_transport_controller_send.h
index 28e0b2d7a7205af86a3729f0487cb3e8d76c89f8..766a2e383970039ea49da11eaeac062ffecdc264 100644
--- a/webrtc/call/rtp_transport_controller_send.h
+++ b/webrtc/call/rtp_transport_controller_send.h
@@ -29,15 +29,24 @@ class RtpTransportControllerSend : public RtpTransportControllerSendInterface {
// Implements RtpTransportControllerSendInterface
PacketRouter* packet_router() override;
+ // TODO(holmer): Temporarily exposed, should be removed and the
+ // appropriate methods should be added to this class instead.
+ // In addition the PacedSender should be driven by this class, either
+ // by owning the process thread, or later by using a task queue.
+ PacedSender* pacer() override;
SendSideCongestionController* send_side_cc() override;
TransportFeedbackObserver* transport_feedback_observer() override;
RtpPacketSender* packet_sender() override;
const RtpKeepAliveConfig& keepalive_config() const override;
+ void SetAllocatedSendBitrateLimits(int min_send_bitrate_bps,
+ int max_padding_bitrate_bps) override;
+
void SetKeepAliveConfig(const RtpKeepAliveConfig& config);
private:
PacketRouter packet_router_;
+ PacedSender pacer_;
SendSideCongestionController send_side_cc_;
RtpKeepAliveConfig keepalive_;
« no previous file with comments | « webrtc/call/fake_rtp_transport_controller_send.h ('k') | webrtc/call/rtp_transport_controller_send.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698