Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: webrtc/rtc_tools/event_log_visualizer/analyzer.cc

Issue 3000773002: Move PacedSender ownership to RtpTransportControllerSend. (Closed)
Patch Set: Fix test bug. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/rtc_tools/DEPS ('k') | webrtc/video/video_send_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1108 matching lines...) Expand 10 before | Expand all | Expand 10 after
1119 for (const LoggedRtcpPacket& rtcp_packet : kv.second) 1119 for (const LoggedRtcpPacket& rtcp_packet : kv.second)
1120 incoming_rtcp.insert( 1120 incoming_rtcp.insert(
1121 std::make_pair(rtcp_packet.timestamp, &rtcp_packet)); 1121 std::make_pair(rtcp_packet.timestamp, &rtcp_packet));
1122 } 1122 }
1123 } 1123 }
1124 1124
1125 SimulatedClock clock(0); 1125 SimulatedClock clock(0);
1126 BitrateObserver observer; 1126 BitrateObserver observer;
1127 RtcEventLogNullImpl null_event_log; 1127 RtcEventLogNullImpl null_event_log;
1128 PacketRouter packet_router; 1128 PacketRouter packet_router;
1129 SendSideCongestionController cc(&clock, &observer, &null_event_log, 1129 PacedSender pacer(&clock, &packet_router, &null_event_log);
1130 &packet_router); 1130 SendSideCongestionController cc(&clock, &observer, &null_event_log, &pacer);
1131 // TODO(holmer): Log the call config and use that here instead. 1131 // TODO(holmer): Log the call config and use that here instead.
1132 static const uint32_t kDefaultStartBitrateBps = 300000; 1132 static const uint32_t kDefaultStartBitrateBps = 300000;
1133 cc.SetBweBitrates(0, kDefaultStartBitrateBps, -1); 1133 cc.SetBweBitrates(0, kDefaultStartBitrateBps, -1);
1134 1134
1135 TimeSeries time_series("Delay-based estimate", LINE_DOT_GRAPH); 1135 TimeSeries time_series("Delay-based estimate", LINE_DOT_GRAPH);
1136 TimeSeries acked_time_series("Acked bitrate", LINE_DOT_GRAPH); 1136 TimeSeries acked_time_series("Acked bitrate", LINE_DOT_GRAPH);
1137 1137
1138 auto rtp_iterator = outgoing_rtp.begin(); 1138 auto rtp_iterator = outgoing_rtp.begin();
1139 auto rtcp_iterator = incoming_rtcp.begin(); 1139 auto rtcp_iterator = incoming_rtcp.begin();
1140 1140
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
1718 plot->AppendTimeSeries(std::move(series.second)); 1718 plot->AppendTimeSeries(std::move(series.second));
1719 } 1719 }
1720 1720
1721 plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin); 1721 plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
1722 plot->SetYAxis(min_y_axis, max_y_axis, "Relative delay (ms)", kBottomMargin, 1722 plot->SetYAxis(min_y_axis, max_y_axis, "Relative delay (ms)", kBottomMargin,
1723 kTopMargin); 1723 kTopMargin);
1724 plot->SetTitle("NetEq timing"); 1724 plot->SetTitle("NetEq timing");
1725 } 1725 }
1726 } // namespace plotting 1726 } // namespace plotting
1727 } // namespace webrtc 1727 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/rtc_tools/DEPS ('k') | webrtc/video/video_send_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698