Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: webrtc/call/rtp_transport_controller_send_interface.h

Issue 3000773002: Move PacedSender ownership to RtpTransportControllerSend. (Closed)
Patch Set: Fix test bug. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_SEND_INTERFACE_H_ 11 #ifndef WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_SEND_INTERFACE_H_
12 #define WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_SEND_INTERFACE_H_ 12 #define WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_SEND_INTERFACE_H_
13 13
14 namespace webrtc { 14 namespace webrtc {
15 15
16 class PacedSender;
16 class PacketRouter; 17 class PacketRouter;
17 class RtpPacketSender; 18 class RtpPacketSender;
18 struct RtpKeepAliveConfig; 19 struct RtpKeepAliveConfig;
19 class SendSideCongestionController; 20 class SendSideCongestionController;
20 class TransportFeedbackObserver; 21 class TransportFeedbackObserver;
21 22
22 // An RtpTransportController should own everything related to the RTP 23 // An RtpTransportController should own everything related to the RTP
23 // transport to/from a remote endpoint. We should have separate 24 // transport to/from a remote endpoint. We should have separate
24 // interfaces for send and receive side, even if they are implemented 25 // interfaces for send and receive side, even if they are implemented
25 // by the same class. This is an ongoing refactoring project. At some 26 // by the same class. This is an ongoing refactoring project. At some
(...skipping 13 matching lines...) Expand all
39 // objects, even in the common case where they are bundled over the 40 // objects, even in the common case where they are bundled over the
40 // same underlying transport. 41 // same underlying transport.
41 // 42 //
42 // Extracting the logic of the webrtc::Transport from BaseChannel and 43 // Extracting the logic of the webrtc::Transport from BaseChannel and
43 // subclasses into a separate class seems to be a prerequesite for 44 // subclasses into a separate class seems to be a prerequesite for
44 // moving the transport here. 45 // moving the transport here.
45 class RtpTransportControllerSendInterface { 46 class RtpTransportControllerSendInterface {
46 public: 47 public:
47 virtual ~RtpTransportControllerSendInterface() {} 48 virtual ~RtpTransportControllerSendInterface() {}
48 virtual PacketRouter* packet_router() = 0; 49 virtual PacketRouter* packet_router() = 0;
50 virtual PacedSender* pacer() = 0;
49 // Currently returning the same pointer, but with different types. 51 // Currently returning the same pointer, but with different types.
50 virtual SendSideCongestionController* send_side_cc() = 0; 52 virtual SendSideCongestionController* send_side_cc() = 0;
51 virtual TransportFeedbackObserver* transport_feedback_observer() = 0; 53 virtual TransportFeedbackObserver* transport_feedback_observer() = 0;
52 54
53 virtual RtpPacketSender* packet_sender() = 0; 55 virtual RtpPacketSender* packet_sender() = 0;
54 virtual const RtpKeepAliveConfig& keepalive_config() const = 0; 56 virtual const RtpKeepAliveConfig& keepalive_config() const = 0;
57
58 // SetAllocatedSendBitrateLimits sets bitrates limits imposed by send codec
59 // settings.
60 // |min_send_bitrate_bps| is the total minimum send bitrate required by all
61 // sending streams. This is the minimum bitrate the PacedSender will use.
62 // Note that SendSideCongestionController::OnNetworkChanged can still be
63 // called with a lower bitrate estimate. |max_padding_bitrate_bps| is the max
64 // bitrate the send streams request for padding. This can be higher than the
65 // current network estimate and tells the PacedSender how much it should max
66 // pad unless there is real packets to send.
67 virtual void SetAllocatedSendBitrateLimits(int min_send_bitrate_bps,
68 int max_padding_bitrate_bps) = 0;
55 }; 69 };
56 70
57 } // namespace webrtc 71 } // namespace webrtc
58 72
59 #endif // WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_SEND_INTERFACE_H_ 73 #endif // WEBRTC_CALL_RTP_TRANSPORT_CONTROLLER_SEND_INTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698