webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm - Issue 3000753002: Add a flags field to video timing extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm

Issue 3000753002: Add a flags field to video timing extension. (Closed)

Patch Set: android fix Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm ('k') | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm

index 4091886dd486eb3d811de000ef6427cf262d2ac1..b50899ed9dffe692b051c71f421960ad5e19698d 100644

--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm

+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm

@@ -657,7 +657,7 @@ CFStringRef ExtractProfile(const cricket::VideoCodec &codec) {

frame.rotation = rotation;

frame.contentType = (_mode == RTCVideoCodecModeScreensharing) ? RTCVideoContentTypeScreenshare :

RTCVideoContentTypeUnspecified;

- frame.isTimingFrame = NO;

+ frame.flags = 0;

kthelgason 2017/08/14 11:32:36 why is this not webrtc::TimingFrameFlags::kInvalid

sprang_webrtc 2017/08/14 11:56:44 You're right, it should be kInvalid.

int qp;

_h264BitstreamParser.ParseBitstream(buffer->data(), buffer->size());