Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: webrtc/api/video_codecs/video_encoder.h

Issue 3000693003: Move kMinPixelsPerFrame constant in VideoStreamEncoder to VideoEncoder::ScalingSettings. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/video_codecs/video_encoder.h
diff --git a/webrtc/api/video_codecs/video_encoder.h b/webrtc/api/video_codecs/video_encoder.h
index 0f21cae13a767dd54ae5ade8c272dbf3dad89564..7a319d721635227aa502eb4141cf36dd37bd6e1b 100644
--- a/webrtc/api/video_codecs/video_encoder.h
+++ b/webrtc/api/video_codecs/video_encoder.h
@@ -75,12 +75,20 @@ class VideoEncoder {
};
struct ScalingSettings {
ScalingSettings(bool on, int low, int high);
+ ScalingSettings(bool on, int low, int high, int min_pixels);
+ ScalingSettings(bool on, int min_pixels);
explicit ScalingSettings(bool on);
ScalingSettings(const ScalingSettings&);
~ScalingSettings();
const bool enabled;
const rtc::Optional<QpThresholds> thresholds;
+
+ // We will never ask for a resolution lower than this.
+ // TODO(kthelgason): Lower this limit when better testing
+ // on MediaCodec and fallback implementations are in place.
+ // See https://bugs.chromium.org/p/webrtc/issues/detail?id=7206
+ const int min_pixels_per_frame = 320 * 180;
brandtr 2017/08/17 12:06:23 kMinPixelsPerFrame? Also, place above the ctors:
åsapersson 2017/08/17 13:22:36 min_pixels_per_frame can be set in the constructor
};
static VideoCodecVP8 GetDefaultVp8Settings();
« no previous file with comments | « no previous file | webrtc/api/video_codecs/video_encoder.cc » ('j') | webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698