Don't blame old-space GC time against a new-space GC that triggered it.

Don't blame old-space GC time against a new-space GC that triggered it.

R=danunez@google.com

Committed: https://github.com/dart-lang/sdk/commit/e77e11ee05552e7bd43aab8e9e1f2bd3b5995b7c

[rmacnak, 2017-08-22 01:13:23]

rmacnak@google.com changed reviewers:
+ asiva@google.com, danunez@google.com

[danunez, 2017-08-22 17:01:27]

lgtm w/ comment

https://codereview.chromium.org/3000293002/diff/1/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

https://codereview.chromium.org/3000293002/diff/1/runtime/vm/heap.cc#newcode416
runtime/vm/heap.cc:416: TIMELINE_FUNCTION_GC_DURATION(thread,
"EvacuateNewGeneration");
I think you'll need to do the same for the Evacuate call here.

[rmacnak, 2017-08-22 17:10:51]

https://codereview.chromium.org/3000293002/diff/1/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

https://codereview.chromium.org/3000293002/diff/1/runtime/vm/heap.cc#newcode416
runtime/vm/heap.cc:416: TIMELINE_FUNCTION_GC_DURATION(thread,
"EvacuateNewGeneration");
On 2017/08/22 17:01:26, danunez wrote:
> I think you'll need to do the same for the Evacuate call here.

There's no trailing old-space GC here to exclude.

[rmacnak, 2017-08-22 17:14:14]

Description was changed from

==========
Don't blame old-space GC time against a new-space GC that triggered it.
==========

to

==========
Don't blame old-space GC time against a new-space GC that triggered it.

R=danunez@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e77e11ee05552e7bd43aab8e9e1f2bd3b5995b7c
==========

[rmacnak, 2017-08-22 17:14:15]

Committed patchset #1 (id:1) manually as
e77e11ee05552e7bd43aab8e9e1f2bd3b5995b7c (presubmit successful).