Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 3000273002: Reverse |rtx_payload_types| map, and rename. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 01d34a76a406c4566e0fcf25b581acdeb4593596..35bb3afeb61ce412b92eee0522b775e09a65394d 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -841,8 +841,8 @@ class FlexfecRenderObserver : public test::EndToEndTest,
(*receive_configs)[0].rtp.rtx_ssrc = test::CallTest::kSendRtxSsrcs[0];
(*receive_configs)[0]
- .rtp.rtx_payload_types[test::CallTest::kVideoSendPayloadType] =
- test::CallTest::kSendRtxPayloadType;
+ .rtp.media_pt_by_rtx_pt[test::CallTest::kSendRtxPayloadType] =
+ test::CallTest::kVideoSendPayloadType;
}
}
@@ -1150,8 +1150,8 @@ void EndToEndTest::DecodesRetransmittedFrame(bool enable_rtx, bool enable_red) {
send_config->rtp.rtx.ssrcs.push_back(kSendRtxSsrcs[0]);
send_config->rtp.rtx.payload_type = kSendRtxPayloadType;
(*receive_configs)[0].rtp.rtx_ssrc = kSendRtxSsrcs[0];
- (*receive_configs)[0].rtp.rtx_payload_types[payload_type_] =
- kSendRtxPayloadType;
+ (*receive_configs)[0].rtp.media_pt_by_rtx_pt[kSendRtxPayloadType] =
+ payload_type_;
}
// Configure encoding and decoding with VP8, since generic packetization
// doesn't support FEC with NACK.
@@ -2678,8 +2678,8 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
send_config->rtp.rtx.ssrcs.push_back(kSendRtxSsrcs[0]);
send_config->rtp.rtx.payload_type = kSendRtxPayloadType;
(*receive_configs)[0].rtp.rtx_ssrc = kSendRtxSsrcs[0];
- (*receive_configs)[0].rtp.rtx_payload_types[kFakeVideoSendPayloadType] =
- kSendRtxPayloadType;
+ (*receive_configs)[0].rtp.media_pt_by_rtx_pt[kSendRtxPayloadType] =
+ kFakeVideoSendPayloadType;
}
// RTT needed for RemoteNtpTimeEstimator for the receive stream.
(*receive_configs)[0].rtp.rtcp_xr.receiver_reference_time_report = true;
@@ -3437,8 +3437,8 @@ TEST_F(EndToEndTest, GetStats) {
(*receive_configs)[i].rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
(*receive_configs)[i].rtp.rtx_ssrc = kSendRtxSsrcs[i];
- (*receive_configs)[i].rtp.rtx_payload_types[kFakeVideoSendPayloadType] =
- kSendRtxPayloadType;
+ (*receive_configs)[i].rtp.media_pt_by_rtx_pt[kSendRtxPayloadType] =
+ kFakeVideoSendPayloadType;
}
for (size_t i = 0; i < kNumSsrcs; ++i)
@@ -4190,8 +4190,8 @@ TEST_F(EndToEndTest, MAYBE_TestFlexfecRtpStatePreservation) {
CreateMatchingReceiveConfigs(&receive_transport);
video_receive_configs_[0].rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
video_receive_configs_[0].rtp.rtx_ssrc = kSendRtxSsrcs[0];
- video_receive_configs_[0].rtp.rtx_payload_types[kVideoSendPayloadType] =
- kSendRtxPayloadType;
+ video_receive_configs_[0].rtp.media_pt_by_rtx_pt[kSendRtxPayloadType] =
+ kVideoSendPayloadType;
// The matching FlexFEC receive config is not created by
// CreateMatchingReceiveConfigs since this is not a test::BaseTest.
@@ -4653,7 +4653,7 @@ TEST_F(EndToEndTest, VerifyDefaultVideoReceiveConfigParameters) {
<< "RTCP XR settings require rtcp-xr to be negotiated.";
EXPECT_EQ(0U, default_receive_config.rtp.rtx_ssrc)
<< "Enabling RTX requires ssrc-group: FID negotiation";
- EXPECT_TRUE(default_receive_config.rtp.rtx_payload_types.empty())
+ EXPECT_TRUE(default_receive_config.rtp.media_pt_by_rtx_pt.empty())
<< "Enabling RTX requires rtpmap: rtx negotiation.";
EXPECT_TRUE(default_receive_config.rtp.extensions.empty())
<< "Enabling RTP extensions require negotiation.";

Powered by Google App Engine
This is Rietveld 408576698