Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Side by Side Diff: webrtc/modules/video_coding/BUILD.gn

Issue 3000263002: H264: Don't disable compiler warning by using NO_THREAD_SAFETY_ANALYSIS. (Closed)
Patch Set: OWNERS file added Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/video_coding/codecs/h264/OWNERS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../webrtc.gni") 9 import("../../webrtc.gni")
10 10
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 "../../common_video", 139 "../../common_video",
140 "../../modules/rtp_rtcp:rtp_rtcp", 140 "../../modules/rtp_rtcp:rtp_rtcp",
141 "../../rtc_base:rtc_base_approved", 141 "../../rtc_base:rtc_base_approved",
142 "../../rtc_base:rtc_numerics", 142 "../../rtc_base:rtc_numerics",
143 "../../rtc_base:rtc_task_queue", 143 "../../rtc_base:rtc_task_queue",
144 "../../rtc_base:sequenced_task_checker", 144 "../../rtc_base:sequenced_task_checker",
145 "../../system_wrappers", 145 "../../system_wrappers",
146 ] 146 ]
147 } 147 }
148 148
149 # TODO(ehmaldonado): Remove once http://bugs.webrtc.org/8090 is fixed.
150 config("webrtc_h264_config") {
151 if (is_clang) {
152 cflags = [ "-Wno-thread-safety-attributes" ]
153 }
154 }
155
156 rtc_static_library("webrtc_h264") { 149 rtc_static_library("webrtc_h264") {
157 sources = [ 150 sources = [
158 "codecs/h264/h264.cc", 151 "codecs/h264/h264.cc",
159 "codecs/h264/include/h264.h", 152 "codecs/h264/include/h264.h",
160 ] 153 ]
161 154
162 if (!build_with_chromium && is_clang) { 155 if (!build_with_chromium && is_clang) {
163 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 156 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
164 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 157 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
165 } 158 }
166 159
167 defines = [] 160 defines = []
168 deps = [ 161 deps = [
169 ":video_coding_utility", 162 ":video_coding_utility",
170 "../../media:rtc_media_base", 163 "../../media:rtc_media_base",
171 "../../rtc_base:rtc_base_approved", 164 "../../rtc_base:rtc_base_approved",
172 "../../system_wrappers", 165 "../../system_wrappers",
173 ] 166 ]
174 167
175 if (rtc_use_h264) { 168 if (rtc_use_h264) {
176 configs += [ ":webrtc_h264_config" ]
177 defines += [ "WEBRTC_USE_H264" ] 169 defines += [ "WEBRTC_USE_H264" ]
178 if (rtc_initialize_ffmpeg) { 170 if (rtc_initialize_ffmpeg) {
179 defines += [ "WEBRTC_INITIALIZE_FFMPEG" ] 171 defines += [ "WEBRTC_INITIALIZE_FFMPEG" ]
180 } 172 }
181 sources += [ 173 sources += [
182 "codecs/h264/h264_decoder_impl.cc", 174 "codecs/h264/h264_decoder_impl.cc",
183 "codecs/h264/h264_decoder_impl.h", 175 "codecs/h264/h264_decoder_impl.h",
184 "codecs/h264/h264_encoder_impl.cc", 176 "codecs/h264/h264_encoder_impl.cc",
185 "codecs/h264/h264_encoder_impl.h", 177 "codecs/h264/h264_encoder_impl.h",
186 ] 178 ]
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 } 635 }
644 636
645 # TODO(jschuh): bugs.webrtc.org/1348: fix this warning. 637 # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
646 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 638 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
647 if (!build_with_chromium && is_clang) { 639 if (!build_with_chromium && is_clang) {
648 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 640 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
649 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 641 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
650 } 642 }
651 } 643 }
652 } 644 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/video_coding/codecs/h264/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698