Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: tools_webrtc/valgrind/webrtc_tests.py

Issue 2999383002: Reland of Stop silently accepting unsupported flags in test binaries (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools_webrtc/gtest-parallel-wrapper.py ('k') | webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools_webrtc/valgrind/webrtc_tests.py
diff --git a/tools_webrtc/valgrind/webrtc_tests.py b/tools_webrtc/valgrind/webrtc_tests.py
index 627025cd75d2413aaf688bf943c2d5dcda08af62..dcd88e8566a10dc8af71383a79cbb8b573a38ebb 100755
--- a/tools_webrtc/valgrind/webrtc_tests.py
+++ b/tools_webrtc/valgrind/webrtc_tests.py
@@ -24,6 +24,7 @@
specific suppressions in our own files.
"""
+import argparse
import logging
import optparse
import os
@@ -124,6 +125,15 @@
help="run the tests with --test-launcher-shard-index")
options, args = parser.parse_args()
+ ignore_parser = argparse.ArgumentParser()
+ # Ignore Chromium-specific flags
+ # TODO(oprypin): Remove (bugs.webrtc.org/8115)
+ ignore_parser.add_argument('--isolated-script-test-output',
+ type=str, default=None)
+ ignore_parser.add_argument('--isolated-script-test-chartjson-output',
+ type=str, default=None)
+ _, args = ignore_parser.parse_known_args(args)
+
if options.verbose:
logging_utils.config_root(logging.DEBUG)
else:
« no previous file with comments | « tools_webrtc/gtest-parallel-wrapper.py ('k') | webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698