Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2140)

Unified Diff: webrtc/test/test_main.cc

Issue 2999383002: Reland of Stop silently accepting unsupported flags in test binaries (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/test/test_main.cc
diff --git a/webrtc/test/test_main.cc b/webrtc/test/test_main.cc
index 2d7dbe2225c6c2e6da3d341e0817d42ad885c495..3f6d4f187c9ef0e337598398fcc4a6a26cc91660 100644
--- a/webrtc/test/test_main.cc
+++ b/webrtc/test/test_main.cc
@@ -19,6 +19,11 @@
#if defined(WEBRTC_IOS)
#include "webrtc/test/ios/test_support.h"
+
+DEFINE_string(NSTreatUnknownArgumentsAsOpen, "",
+ "Intentionally ignored flag intended for iOS simulator.");
+DEFINE_string(ApplePersistenceIgnoreState, "",
+ "Intentionally ignored flag intended for iOS simulator.");
#endif
DEFINE_bool(logs, false, "print logs to stderr");
@@ -36,9 +41,6 @@
if (rtc::LogMessage::GetLogToDebug() > rtc::LS_INFO)
rtc::LogMessage::LogToDebug(rtc::LS_INFO);
- // AllowCommandLineParsing allows us to ignore flags passed on to us by
- // Chromium build bots without having to explicitly disable them.
- google::AllowCommandLineReparsing();
google::ParseCommandLineFlags(&argc, &argv, false);
webrtc::test::SetExecutablePath(argv[0]);
« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc ('k') | webrtc/voice_engine/test/auto_test/voe_standard_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698