Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/congestion_window.cc

Issue 2999073002: Tweaked version of BBR for WebRTC. (Closed)
Patch Set: Fixed compilation errors. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/estimators/congestion_window.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/congestion_window.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/congestion_window.cc
index 3d357704b582f892a7429125a87593fb2927921f..3df12193b32be23fa597b636de1042116a5bac99 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/congestion_window.cc
+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/congestion_window.cc
@@ -37,8 +37,6 @@ int CongestionWindow::GetCongestionWindow(BbrBweSender::Mode mode,
int64_t bandwidth_estimate_bps,
rtc::Optional<int64_t> min_rtt_ms,
float gain) {
- if (mode == BbrBweSender::PROBE_RTT)
- return CongestionWindow::kMinimumCongestionWindowBytes;
philipel 2017/08/17 12:52:27 Why don't we have a min congestion window any more
gnish1 2017/08/17 15:37:49 This implementation of BBR doesn't use minimum con
return GetTargetCongestionWindow(bandwidth_estimate_bps, min_rtt_ms, gain);
}
@@ -57,14 +55,13 @@ int CongestionWindow::GetTargetCongestionWindow(
// If we have no rtt sample yet, return the starting congestion window size.
if (!min_rtt_ms)
return gain * kStartingCongestionWindowBytes;
- int bdp = *min_rtt_ms * bandwidth_estimate_bps;
+ int bdp = *min_rtt_ms * bandwidth_estimate_bps / 8000;
philipel 2017/08/17 12:52:27 Why do we suddenly measure bandwidth delay product
gnish1 2017/08/17 15:37:49 Because packet's are measured in bytes, so data_in
int congestion_window = bdp * gain;
// Congestion window could be zero in rare cases, when either no bandwidth
// estimate is available, or path's min_rtt value is zero.
if (!congestion_window)
congestion_window = gain * kStartingCongestionWindowBytes;
- return std::max(congestion_window,
- CongestionWindow::kMinimumCongestionWindowBytes);
+ return congestion_window;
}
} // namespace bwe
} // namespace testing

Powered by Google App Engine
This is Rietveld 408576698