Add flag enabling more packets to be retransmittable.

webrtc/modules/rtp_rtcp/source/rtp_format_vp8_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 77 matching lines @@
     hdr_info_.nonReference = false;
     hdr_info_.temporalIdx = kNoTemporalIdx;
     hdr_info_.layerSync = false;
     hdr_info_.tl0PicIdx = kNoTl0PicIdx;
     hdr_info_.keyIdx = kNoKeyIdx;
     if (helper_ != NULL)
       return false;
     helper_ = new test::RtpFormatVp8TestHelper(&hdr_info_);
     return helper_->Init(partition_sizes, num_partitions);
   }
-
   RTPVideoHeaderVP8 hdr_info_;
   test::RtpFormatVp8TestHelper* helper_;
 };
 
 TEST_F(RtpPacketizerVp8Test, TestStrictMode) {
   const size_t kSizeVector[] = {10, 8, 27};
   const size_t kNumPartitions = GTEST_ARRAY_SIZE_(kSizeVector);
   ASSERT_TRUE(Init(kSizeVector, kNumPartitions));
 
   hdr_info_.pictureId = 200;
@@ skipping 414 matching lines @@
   CHECK_ARRAY_SIZE(kExpectedNum, kExpectedFragStart);
   ASSERT_EQ(num_packets, kExpectedNum);
 
   helper_->GetAllPacketsAndCheck(&packetizer,
                                  kExpectedSizes,
                                  kExpectedPart,
                                  kExpectedFragStart,
                                  kExpectedNum);
 }
 
+TEST_F(RtpPacketizerVp8Test, RetransmitNoTL) {
+  hdr_info_.temporalIdx = kNoTemporalIdx;
+  RtpPacketizerVp8 packetizer(hdr_info_, 1500, 0, kAggregate);
+
+  EXPECT_EQ(kDontRetransmit, packetizer.GetStorageType(kRetransmitOff));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitBaseLayer));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitHigherLayers));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kConditionallyRetransmitHigherLayers));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitAllPackets));
+}
+
+TEST_F(RtpPacketizerVp8Test, RetransmitTL0) {
+  hdr_info_.temporalIdx = 0;
+  RtpPacketizerVp8 packetizer(hdr_info_, 1500, 0, kAggregate);
+
+  EXPECT_EQ(kDontRetransmit, packetizer.GetStorageType(kRetransmitOff));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitBaseLayer));
+  EXPECT_EQ(kDontRetransmit,
+            packetizer.GetStorageType(kRetransmitHigherLayers));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitBaseLayer |
+                                      kRetransmitHigherLayers));
+  EXPECT_EQ(kDontRetransmit,
+            packetizer.GetStorageType(kConditionallyRetransmitHigherLayers));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitBaseLayer |
+                                      kConditionallyRetransmitHigherLayers));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitAllPackets));
+}
+
+TEST_F(RtpPacketizerVp8Test, RetransmitTL1_2) {

[danilchap, 2017/08/29 17:31:19]

_ is discouraged in test names.
https://github.com/google/googletest/blob/master/googletest/docs/FAQ.md#why-s...

[sprang_webrtc, 2017/08/31 15:54:28]

Done.

+  for (int tid = 1; tid <= 2; ++tid) {
+    hdr_info_.temporalIdx = tid;
+    RtpPacketizerVp8 packetizer(hdr_info_, 1500, 0, kAggregate);
+
+    EXPECT_EQ(kDontRetransmit, packetizer.GetStorageType(kRetransmitOff));
+    EXPECT_EQ(kDontRetransmit, packetizer.GetStorageType(kRetransmitBaseLayer));
+    EXPECT_EQ(kAllowRetransmission,
+              packetizer.GetStorageType(kRetransmitHigherLayers));
+    EXPECT_EQ(kAllowRetransmission,
+              packetizer.GetStorageType(kRetransmitBaseLayer |
+                                        kRetransmitHigherLayers));
+    EXPECT_EQ(kDontRetransmit,
+              packetizer.GetStorageType(kConditionallyRetransmitHigherLayers));
+    EXPECT_EQ(kDontRetransmit,
+              packetizer.GetStorageType(kRetransmitBaseLayer |
+                                        kConditionallyRetransmitHigherLayers));
+    EXPECT_EQ(kAllowRetransmission,
+              packetizer.GetStorageType(kRetransmitAllPackets));
+  }
+}
+
+TEST_F(RtpPacketizerVp8Test, RetransmitTL3) {

[danilchap, 2017/08/29 17:31:19]

how TL3 is different from TL2/TL1?

[sprang_webrtc, 2017/08/31 15:54:28]

It was only different in an earlier revision of this cl. Removed.

+  hdr_info_.temporalIdx = 3;
+  RtpPacketizerVp8 packetizer(hdr_info_, 1500, 0, kAggregate);
+
+  EXPECT_EQ(kDontRetransmit, packetizer.GetStorageType(kRetransmitOff));
+  EXPECT_EQ(kDontRetransmit, packetizer.GetStorageType(kRetransmitBaseLayer));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitHigherLayers));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitBaseLayer |
+                                      kRetransmitHigherLayers));
+  EXPECT_EQ(kDontRetransmit,
+            packetizer.GetStorageType(kConditionallyRetransmitHigherLayers));
+  EXPECT_EQ(kDontRetransmit,
+            packetizer.GetStorageType(kRetransmitBaseLayer |
+                                      kConditionallyRetransmitHigherLayers));
+  EXPECT_EQ(kAllowRetransmission,
+            packetizer.GetStorageType(kRetransmitAllPackets));
+}
+
 class RtpDepacketizerVp8Test : public ::testing::Test {
  protected:
   RtpDepacketizerVp8Test()
       : depacketizer_(RtpDepacketizer::Create(kRtpVideoVp8)) {}
 
   void ExpectPacket(RtpDepacketizer::ParsedPayload* parsed_payload,
                     const uint8_t* data,
                     size_t length) {
     ASSERT_TRUE(parsed_payload != NULL);
     EXPECT_THAT(std::vector<uint8_t>(
@@ skipping 179 matching lines @@
             input_header.layerSync);
 }
 
 TEST_F(RtpDepacketizerVp8Test, TestEmptyPayload) {
   // Using a wild pointer to crash on accesses from inside the depacketizer.
   uint8_t* garbage_ptr = reinterpret_cast<uint8_t*>(0x4711);
   RtpDepacketizer::ParsedPayload payload;
   EXPECT_FALSE(depacketizer_->Parse(&payload, garbage_ptr, 0));
 }
 }  // namespace webrtc