Add flag enabling more packets to be retransmittable.

webrtc/modules/rtp_rtcp/source/rtp_format_vp8.cc

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 200 matching lines @@
   return true;
 }
 
 ProtectionType RtpPacketizerVp8::GetProtectionType() {
   bool protect =
       hdr_info_.temporalIdx == 0 || hdr_info_.temporalIdx == kNoTemporalIdx;
   return protect ? kProtectedPacket : kUnprotectedPacket;
 }
 
 StorageType RtpPacketizerVp8::GetStorageType(uint32_t retransmission_settings) {
-  if (hdr_info_.temporalIdx == 0 &&
-      !(retransmission_settings & kRetransmitBaseLayer)) {
+  if (retransmission_settings == kRetransmitOff)
     return kDontRetransmit;
+
+  if (retransmission_settings == kRetransmitAllPackets)
+    return kAllowRetransmission;
+
+  if (hdr_info_.temporalIdx == kNoTemporalIdx)

[danilchap, 2017/08/29 17:31:19]

if retransmission_settings == kRetransmitFECPackets, should this packet be
retransmitted?
Or odd configurations are not supported?

[sprang_webrtc, 2017/08/31 15:54:28]

I don't think fec makes sense here. This method is only used to determine the
storage type for the frame this packetizer contains. FEC packet generation lives
separately.

+    return kAllowRetransmission;
+
+  if ((retransmission_settings & kRetransmitBaseLayer) &&
+      hdr_info_.temporalIdx == 0) {
+    return kAllowRetransmission;
   }
-  if (hdr_info_.temporalIdx != kNoTemporalIdx &&
-             hdr_info_.temporalIdx > 0 &&
-             !(retransmission_settings & kRetransmitHigherLayers)) {
-    return kDontRetransmit;
+
+  if ((retransmission_settings & kRetransmitHigherLayers) &&
+      hdr_info_.temporalIdx > 0) {
+    return kAllowRetransmission;
   }
-  return kAllowRetransmission;
+
+  return kDontRetransmit;
 }
 
 std::string RtpPacketizerVp8::ToString() {
   return "RtpPacketizerVp8";
 }
 
 int RtpPacketizerVp8::GeneratePackets() {
   if (max_payload_len_ < vp8_fixed_payload_descriptor_bytes_ +
                              PayloadDescriptorExtraLength() + 1 +
                              last_packet_reduction_len_) {
@@ skipping 454 matching lines @@
   if (ParseVP8FrameSize(parsed_payload, payload_data, payload_data_length) !=
       0) {
     return false;
   }
 
   parsed_payload->payload = payload_data;
   parsed_payload->payload_length = payload_data_length;
   return true;
 }
 }  // namespace webrtc