Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: webrtc/media/engine/webrtcvideoengine.cc

Issue 2998843002: Default enable content type rtp header extension (Closed)
Patch Set: Remove unit test for the removed code Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvideoengine_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine.cc
diff --git a/webrtc/media/engine/webrtcvideoengine.cc b/webrtc/media/engine/webrtcvideoengine.cc
index 6813ada0ca4c657e14e03ab470ef5deb0181b5a9..52db773ba0e6cce747c52174109229097961b09f 100644
--- a/webrtc/media/engine/webrtcvideoengine.cc
+++ b/webrtc/media/engine/webrtcvideoengine.cc
@@ -55,13 +55,6 @@ bool IsFlexfecAdvertisedFieldTrialEnabled() {
return webrtc::field_trial::IsEnabled("WebRTC-FlexFEC-03-Advertised");
}
-// If this field trial is enabled, we will report VideoContentType RTP extension
-// in capabilities (thus, it will end up in the default SDP and extension will
-// be sent for all key-frames).
-bool IsVideoContentTypeExtensionFieldTrialEnabled() {
- return webrtc::field_trial::IsEnabled("WebRTC-VideoContentTypeExtension");
-}
-
// An encoder factory that wraps Create requests for simulcastable codec types
// with a webrtc::SimulcastEncoderAdapter. Non simulcastable codec type
// requests are just passed through to the contained encoder factory.
@@ -430,11 +423,9 @@ RtpCapabilities WebRtcVideoEngine::GetCapabilities() const {
capabilities.header_extensions.push_back(
webrtc::RtpExtension(webrtc::RtpExtension::kPlayoutDelayUri,
webrtc::RtpExtension::kPlayoutDelayDefaultId));
- if (IsVideoContentTypeExtensionFieldTrialEnabled()) {
- capabilities.header_extensions.push_back(
- webrtc::RtpExtension(webrtc::RtpExtension::kVideoContentTypeUri,
- webrtc::RtpExtension::kVideoContentTypeDefaultId));
- }
+ capabilities.header_extensions.push_back(
+ webrtc::RtpExtension(webrtc::RtpExtension::kVideoContentTypeUri,
+ webrtc::RtpExtension::kVideoContentTypeDefaultId));
// TODO(ilnik): Add kVideoTimingUri/kVideoTimingDefaultId to capabilities.
// Possibly inside field trial.
return capabilities;
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvideoengine_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698