webrtc/modules/video_coding/video_codec_initializer.cc - Issue 2998293002: Make CodecType conversion functions non-optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/video_codec_initializer.cc

Issue 2998293002: Make CodecType conversion functions non-optional. (Closed)

Patch Set: Keep old functions for backwards-compat Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/video_codec_initializer.cc

diff --git a/webrtc/modules/video_coding/video_codec_initializer.cc b/webrtc/modules/video_coding/video_codec_initializer.cc

index df8f1365419dc4d405b3c4f556a505c4cf194312..d274bf16a753030ad40d6e3e7463ca0252585455 100644

--- a/webrtc/modules/video_coding/video_codec_initializer.cc

+++ b/webrtc/modules/video_coding/video_codec_initializer.cc

@@ -104,8 +104,7 @@ VideoCodec VideoCodecInitializer::VideoEncoderConfigToVideoCodec(

VideoCodec video_codec;

memset(&video_codec, 0, sizeof(video_codec));

- video_codec.codecType = PayloadNameToCodecType(payload_name)

- .value_or(VideoCodecType::kVideoCodecGeneric);

+ video_codec.codecType = PayloadStringToCodecType(payload_name);

switch (config.content_type) {

case VideoEncoderConfig::ContentType::kRealtimeVideo: