webrtc/modules/video_coding/utility/ivf_file_writer.cc - Issue 2998293002: Make CodecType conversion functions non-optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/utility/ivf_file_writer.cc

Issue 2998293002: Make CodecType conversion functions non-optional. (Closed)

Patch Set: Keep old functions for backwards-compat Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/utility/ivf_file_writer.cc

diff --git a/webrtc/modules/video_coding/utility/ivf_file_writer.cc b/webrtc/modules/video_coding/utility/ivf_file_writer.cc

index ce3919d7efeff01ae66e75f1c832139cca8f1bd4..78e956aacd53a49c677af9bdb0bc2a37b6ed6e71 100644

--- a/webrtc/modules/video_coding/utility/ivf_file_writer.cc

+++ b/webrtc/modules/video_coding/utility/ivf_file_writer.cc

@@ -123,7 +123,7 @@ bool IvfFileWriter::InitFromFirstFrame(const EncodedImage& encoded_image,

return false;

const char* codec_name =

- CodecTypeToPayloadName(codec_type_).value_or("Unknown");

+ CodecTypeToPayloadString(codec_type_);

LOG(LS_WARNING) << "Created IVF file for codec data of type " << codec_name

<< " at resolution " << width_ << " x " << height_

<< ", using " << (using_capture_timestamps_ ? "1" : "90")