Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine.cc

Issue 2998293002: Make CodecType conversion functions non-optional. (Closed)
Patch Set: Keep old functions for backwards-compat Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1712 matching lines...) Expand 10 before | Expand all | Expand 10 after
1723 RTC_DCHECK_GT(parameters_.encoder_config.number_of_streams, 0); 1723 RTC_DCHECK_GT(parameters_.encoder_config.number_of_streams, 0);
1724 1724
1725 AllocatedEncoder new_encoder = 1725 AllocatedEncoder new_encoder =
1726 CreateVideoEncoder(codec_settings.codec, force_encoder_allocation); 1726 CreateVideoEncoder(codec_settings.codec, force_encoder_allocation);
1727 parameters_.config.encoder_settings.encoder = new_encoder.encoder; 1727 parameters_.config.encoder_settings.encoder = new_encoder.encoder;
1728 parameters_.config.encoder_settings.full_overuse_time = new_encoder.external; 1728 parameters_.config.encoder_settings.full_overuse_time = new_encoder.external;
1729 parameters_.config.encoder_settings.payload_name = codec_settings.codec.name; 1729 parameters_.config.encoder_settings.payload_name = codec_settings.codec.name;
1730 parameters_.config.encoder_settings.payload_type = codec_settings.codec.id; 1730 parameters_.config.encoder_settings.payload_type = codec_settings.codec.id;
1731 if (new_encoder.external) { 1731 if (new_encoder.external) {
1732 webrtc::VideoCodecType type = 1732 webrtc::VideoCodecType type =
1733 webrtc::PayloadNameToCodecType(codec_settings.codec.name) 1733 webrtc::PayloadStringToCodecType(codec_settings.codec.name);
1734 .value_or(webrtc::kVideoCodecUnknown);
1735 parameters_.config.encoder_settings.internal_source = 1734 parameters_.config.encoder_settings.internal_source =
1736 external_encoder_factory_->EncoderTypeHasInternalSource(type); 1735 external_encoder_factory_->EncoderTypeHasInternalSource(type);
1737 } else { 1736 } else {
1738 parameters_.config.encoder_settings.internal_source = false; 1737 parameters_.config.encoder_settings.internal_source = false;
1739 } 1738 }
1740 parameters_.config.rtp.ulpfec = codec_settings.ulpfec; 1739 parameters_.config.rtp.ulpfec = codec_settings.ulpfec;
1741 parameters_.config.rtp.flexfec.payload_type = 1740 parameters_.config.rtp.flexfec.payload_type =
1742 codec_settings.flexfec_payload_type; 1741 codec_settings.flexfec_payload_type;
1743 1742
1744 // Set RTX payload type if RTX is enabled. 1743 // Set RTX payload type if RTX is enabled.
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
2168 return rtc::Optional<uint32_t>(); 2167 return rtc::Optional<uint32_t>();
2169 } else { 2168 } else {
2170 return rtc::Optional<uint32_t>(primary_ssrcs[0]); 2169 return rtc::Optional<uint32_t>(primary_ssrcs[0]);
2171 } 2170 }
2172 } 2171 }
2173 2172
2174 WebRtcVideoChannel::WebRtcVideoReceiveStream::AllocatedDecoder 2173 WebRtcVideoChannel::WebRtcVideoReceiveStream::AllocatedDecoder
2175 WebRtcVideoChannel::WebRtcVideoReceiveStream::CreateOrReuseVideoDecoder( 2174 WebRtcVideoChannel::WebRtcVideoReceiveStream::CreateOrReuseVideoDecoder(
2176 std::vector<AllocatedDecoder>* old_decoders, 2175 std::vector<AllocatedDecoder>* old_decoders,
2177 const VideoCodec& codec) { 2176 const VideoCodec& codec) {
2178 webrtc::VideoCodecType type = webrtc::PayloadNameToCodecType(codec.name) 2177 webrtc::VideoCodecType type = webrtc::PayloadStringToCodecType(codec.name);
2179 .value_or(webrtc::kVideoCodecUnknown);
2180 2178
2181 for (size_t i = 0; i < old_decoders->size(); ++i) { 2179 for (size_t i = 0; i < old_decoders->size(); ++i) {
2182 if ((*old_decoders)[i].type == type) { 2180 if ((*old_decoders)[i].type == type) {
2183 AllocatedDecoder decoder = (*old_decoders)[i]; 2181 AllocatedDecoder decoder = (*old_decoders)[i];
2184 (*old_decoders)[i] = old_decoders->back(); 2182 (*old_decoders)[i] = old_decoders->back();
2185 old_decoders->pop_back(); 2183 old_decoders->pop_back();
2186 return decoder; 2184 return decoder;
2187 } 2185 }
2188 } 2186 }
2189 2187
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
2651 stream.temporal_layer_thresholds_bps.resize(GetDefaultVp9TemporalLayers() - 2649 stream.temporal_layer_thresholds_bps.resize(GetDefaultVp9TemporalLayers() -
2652 1); 2650 1);
2653 } 2651 }
2654 2652
2655 std::vector<webrtc::VideoStream> streams; 2653 std::vector<webrtc::VideoStream> streams;
2656 streams.push_back(stream); 2654 streams.push_back(stream);
2657 return streams; 2655 return streams;
2658 } 2656 }
2659 2657
2660 } // namespace cricket 2658 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc ('k') | webrtc/modules/video_coding/codecs/test/videoprocessor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698