Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2998283002: [pinpoint] Add GTest support to quest_generator. (Closed)

Created:
3 years, 4 months ago by dtu
Modified:
3 years, 3 months ago
Reviewers:
perezju, shatch, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -34 lines) Patch
M dashboard/dashboard/pinpoint/handlers/quest_generator.py View 1 4 chunks +78 lines, -26 lines 0 comments Download
M dashboard/dashboard/pinpoint/handlers/quest_generator_test.py View 1 8 chunks +106 lines, -8 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/quest/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
dtu
3 years, 4 months ago (2017-08-23 07:24:59 UTC) #2
perezju
lgtm, this came out pretty neatly organized!
3 years, 4 months ago (2017-08-23 09:16:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2998283002/20001
3 years, 3 months ago (2017-08-25 00:41:55 UTC) #7
commit-bot: I haz the power
3 years, 3 months ago (2017-08-25 01:11:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698