Completed the functionalities of SrtpTransport.

webrtc/pc/rtptransport.h

 /*
  *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 38 matching lines @@
 
   PacketTransportInterface* GetRtpPacketTransport() const override;
   PacketTransportInterface* GetRtcpPacketTransport() const override;
 
   // TODO(zstein): Use these RtcpParameters for configuration elsewhere.
   RTCError SetRtcpParameters(const RtcpParameters& parameters) override;
   RtcpParameters GetRtcpParameters() const override;
 
   bool IsWritable(bool rtcp) const override;
 
+  bool SendRtpPacket(rtc::CopyOnWriteBuffer* packet,
+                     const rtc::PacketOptions& options) override;
+
+  bool SendRtcpPacket(rtc::CopyOnWriteBuffer* packet,
+                      const rtc::PacketOptions& options) override;
+
   bool SendPacket(bool rtcp,
                   rtc::CopyOnWriteBuffer* packet,
                   const rtc::PacketOptions& options,
                   int flags) override;

[Taylor Brandstetter, 2017/08/30 21:24:26]

Since BaseChannel now goes through Send[Rtp|Rtcp]Packet, can SendPacket be made
private?

I guess SendRtpPacket and SendRtcpPacket would need the "flags" argument then,
for SrtpTransport to pass through to RtpTransport, which you wanted to avoid.
But that seems preferable to having two ways to send packets in the public
interface.

[Zhi Huang, 2017/08/31 17:42:41]

OK. Then we don't even need SendPacket to be part of RtpTransportInternal which
would simplify the code.

 
   bool HandlesPayloadType(int payload_type) const override;
 
   void AddHandledPayloadType(int payload_type) override;
 
  protected:
   // TODO(zstein): Remove this when we remove RtpTransportAdapter.
   RtpTransportAdapter* GetInternal() override;
 
  private:
@@ skipping 25 matching lines @@
   bool rtcp_ready_to_send_ = false;
 
   RtcpParameters rtcp_parameters_;
 
   cricket::BundleFilter bundle_filter_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_PC_RTPTRANSPORT_H_