desktopCapture: minimized window shouldn't be treated as on-top on Win10

webrtc/modules/desktop_capture/cropping_window_capturer_win.cc

Index: webrtc/modules/desktop_capture/cropping_window_capturer_win.cc
diff --git a/webrtc/modules/desktop_capture/cropping_window_capturer_win.cc b/webrtc/modules/desktop_capture/cropping_window_capturer_win.cc
index b7c71c835c265c9bcd705a95496e941c996f80ff..5e831eb5dfb6a672717330c45fb9d1450d08dd79 100644
--- a/webrtc/modules/desktop_capture/cropping_window_capturer_win.cc
+++ b/webrtc/modules/desktop_capture/cropping_window_capturer_win.cc
@@ -42,11 +42,6 @@ BOOL CALLBACK TopWindowVerifier(HWND hwnd, LPARAM param) {
   TopWindowVerifierContext* context =
       reinterpret_cast<TopWindowVerifierContext*>(param);
 
-  if (hwnd == context->selected_window) {
-    context->is_top_window = true;
-    return FALSE;
-  }
-
   // Ignore the excluded window.
   if (hwnd == context->excluded_window) {
     return TRUE;
@@ -57,6 +52,10 @@ BOOL CALLBACK TopWindowVerifier(HWND hwnd, LPARAM param) {
     return TRUE;
   }
 
+  if (hwnd == context->selected_window) {

[Hzj_jie, 2017/08/07 19:28:29]

After this change, unnecessary checks for other windows will be performed. A
simple approach can be adding
====================
if (IsIconic(selected_window_) || !IsWindowVisible(selected_window_)) {
  return false;
}
====================
in ShouldUseScreenCapturer() around line 129.

P.S. Several more suggestions:
1. Add a RTC_DCHECK_NE in the contructor of TopWindowVerifierContext to ensure
excluded_window != selected_window.
2. Move initialization of selected_window_rect also into the contructor.
3. Remove selected_window_process_id.
4. const selected_window / excluded_window / selected_window_rect.

Since you are touching this file, if you are not interested in applying these
changes, you can add TODOs in TopWindowVerifierContext. Thank you.

+    context->is_top_window = true;
+    return FALSE;
+  }
   // Ignore descendant/owned windows since we want to capture them.
   // This check does not work for tooltips and context menus. Drop down menus
   // and popup windows are fine.