Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: webrtc/rtc_tools/event_log_visualizer/main.cc

Issue 2996953002: Make path to wav file for jitter buffer simulation in event_log_visualizer configurable. (Closed)
Patch Set: Adressed review comment and implemented 2nd option (use const std:string and assign ressource path … Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/rtc_tools/event_log_visualizer/main.cc
diff --git a/webrtc/rtc_tools/event_log_visualizer/main.cc b/webrtc/rtc_tools/event_log_visualizer/main.cc
index 7df0374484aec628b85e76f2884ab14054c189e7..8d3a433b0c8b98ecafff82901ce49f540945a42c 100644
--- a/webrtc/rtc_tools/event_log_visualizer/main.cc
+++ b/webrtc/rtc_tools/event_log_visualizer/main.cc
@@ -88,6 +88,9 @@ DEFINE_string(
"E.g. running with --force_fieldtrials=WebRTC-FooFeature/Enabled/"
" will assign the group Enabled to field trial WebRTC-FooFeature. Multiple "
"trials are separated by \"/\"");
+DEFINE_string(wav_filename,
+ "",
+ "Path to wav file used for simulation of jitter buffer");
DEFINE_bool(help, false, "prints this message");
DEFINE_bool(
@@ -241,11 +244,14 @@ int main(int argc, char* argv[]) {
}
if (FLAG_plot_all || FLAG_plot_audio_jitter_buffer) {
- analyzer.CreateAudioJitterBufferGraph(
- webrtc::test::ResourcePath(
- "audio_processing/conversational_speech/EN_script2_F_sp2_B1",
- "wav"),
- 48000, collection->AppendNewPlot());
+ const std::string wav_path =
+ (strlen(FLAG_wav_filename) == 0)
+ ? webrtc::test::ResourcePath(
+ "audio_processing/conversational_speech/EN_script2_F_sp2_B1",
+ "wav")
+ : FLAG_wav_filename;
+ analyzer.CreateAudioJitterBufferGraph(FLAG_wav_filename, 48000,
hlundin-webrtc 2017/08/15 13:51:17 This must be a bug. Now you are always using the F
owb1 2017/08/16 08:24:05 You are right. This was a bug. I reverted to the f
+ collection->AppendNewPlot());
}
collection->Draw();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698