Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log.cc

Issue 2996933003: Add logging of host lookups made by TurnPort to the RtcEventLog. (Closed)
Patch Set: review Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log.cc
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.cc b/webrtc/logging/rtc_event_log/rtc_event_log.cc
index e661e679828dc401ede7bfbce978fd09ae040a7b..33859ac68b5260c18a0c5dec4ec1e41664b1a95b 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log.cc
+++ b/webrtc/logging/rtc_event_log/rtc_event_log.cc
@@ -94,6 +94,9 @@ class RtcEventLogImpl final : public RtcEventLog {
void LogProbeResultFailure(int id,
ProbeFailureReason failure_reason) override;
+ void LogHostLookupResult(int error,
+ int64_t elapsed_time_in_milliseconds) override;
+
private:
// Private constructor to ensure that creation is done by RtcEventLog::Create.
RtcEventLogImpl();
@@ -565,6 +568,18 @@ void RtcEventLogImpl::LogProbeResult(int id,
StoreEvent(std::move(event));
}
+void RtcEventLogImpl::LogHostLookupResult(
+ int error,
+ int64_t elapsed_time_in_milliseconds) {
terelius 2017/08/21 09:38:14 nit: I'd prefer changing this to "host_lookup_time
+ std::unique_ptr<rtclog::Event> event(new rtclog::Event());
+ event->set_timestamp_us(rtc::TimeMicros());
+ event->set_type(rtclog::Event::HOST_LOOKUP_EVENT);
+ auto result = event->mutable_host_lookup_result();
+ result->set_error(error);
+ result->set_host_lookup_time_ms(elapsed_time_in_milliseconds);
+ StoreEvent(std::move(event));
+}
+
void RtcEventLogImpl::StoreEvent(std::unique_ptr<rtclog::Event> event) {
RTC_DCHECK(event.get() != nullptr);
if (!event_queue_.Insert(&event)) {

Powered by Google App Engine
This is Rietveld 408576698