Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: webrtc/p2p/base/port_unittest.cc

Issue 2996933003: Add logging of host lookups made by TurnPort to the RtcEventLog. (Closed)
Patch Set: review - remove strings from proto Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/port_unittest.cc
diff --git a/webrtc/p2p/base/port_unittest.cc b/webrtc/p2p/base/port_unittest.cc
index 757c1b31bff009c3b300a0a6a6c19fabcc2a2e40..3698de77df153fa5eb03423ece20b31d0c20e484 100644
--- a/webrtc/p2p/base/port_unittest.cc
+++ b/webrtc/p2p/base/port_unittest.cc
@@ -533,10 +533,14 @@ class PortTest : public testing::Test, public sigslot::has_slots<> {
PacketSocketFactory* socket_factory,
ProtocolType int_proto, ProtocolType ext_proto,
const rtc::SocketAddress& server_addr) {
- return TurnPort::Create(&main_, socket_factory, MakeNetwork(addr), 0, 0,
+ uint16_t min_port = 0;
terelius 2017/08/18 11:41:33 Should these be const? Maybe constexpr uint16_t kM
+ uint16_t max_port = 0;
+ webrtc::RtcEventLog* event_log = nullptr;
+ return TurnPort::Create(&main_, socket_factory, MakeNetwork(addr),
+ min_port, max_port,
username_, password_,
ProtocolAddress(server_addr, int_proto),
- kRelayCredentials, 0, std::string());
+ kRelayCredentials, 0, std::string(), event_log);
}
RelayPort* CreateGturnPort(const SocketAddress& addr,
ProtocolType int_proto, ProtocolType ext_proto) {

Powered by Google App Engine
This is Rietveld 408576698