BWE allocation strategy

webrtc/api/peerconnectioninterface.h

Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index ee0121246de51b8670d350c678ab8fd1d35f7952..1c028bf6a1280844b655c258c8bdfae44d229b84 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -84,6 +84,7 @@
 #include "webrtc/api/stats/rtcstatscollectorcallback.h"
 #include "webrtc/api/statstypes.h"
 #include "webrtc/api/umametrics.h"
+#include "webrtc/base/bitrateallocationstrategy.h"
 #include "webrtc/base/fileutils.h"
 #include "webrtc/base/network.h"
 #include "webrtc/base/rtccertificate.h"
@@ -759,6 +760,13 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
     return RTCError::OK();
   }
 
+  // SetBitrateAllocationStrategy sets current strategy. If not set default
+  // WEBRTC allocator will be used. May be changed during an active session.
+  virtual RTCError SetBitrateAllocationStrategy(

[stefan-webrtc, 2017/08/14 07:46:03]

I would prefer if we could pass the allocation strategy to PeerConnection and
Call upon creation via the constructor instead of using a setter. It's easier to
see life time, and doesn't require locks.

It should be doable by adding an argument to this method:
https://cs.chromium.org/chromium/src/third_party/webrtc/pc/peerconnectionfact...

WDYT?

[alexnarest, 2017/08/15 06:02:36]

Helper would let users to change strategies during a call. For example audio
only hangout session may not need a custom strategy but as soon as video/screen
share tracks are added it may want to change allocations. Having strategy
allocated in constructor will require users to implement allocations even for
the cases the default implementation is ok.

+      rtc::BitrateAllocationStrategy* bitrate_allocation_strategy) {
+    return RTCError(RTCErrorType::UNSUPPORTED_OPERATION);
+  }
+
   // Returns the current SignalingState.
   virtual SignalingState signaling_state() = 0;
   virtual IceConnectionState ice_connection_state() = 0;