Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2996643002: BWE allocation strategy
Patch Set: BWE allocation strategy Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | webrtc/call/bitrate_allocator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index 632fc3ca9f15b7146e32e17d33de2e7808e1e246..7cd07353e196da731d0a4f51fade1c267bc91bf4 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -89,6 +89,7 @@
#include "webrtc/media/base/mediachannel.h"
#include "webrtc/media/base/videocapturer.h"
#include "webrtc/p2p/base/portallocator.h"
+#include "webrtc/rtc_base/bitrateallocationstrategy.h"
#include "webrtc/rtc_base/fileutils.h"
#include "webrtc/rtc_base/network.h"
#include "webrtc/rtc_base/rtccertificate.h"
@@ -771,6 +772,14 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// to the provided value.
virtual RTCError SetBitrate(const BitrateParameters& bitrate) = 0;
+ // SetBitrateAllocationStrategy sets current strategy. If not set default
+ // WEBRTC allocator will be used. May be changed during an active session.
Taylor Brandstetter 2017/09/11 16:55:06 nit: "WebRTC"
alexnarest 2017/09/14 13:08:33 Done.
+ // Should be set to nullprt before the strategy destroyed.
+ virtual RTCError SetBitrateAllocationStrategy(
Taylor Brandstetter 2017/09/11 16:55:06 nit: "Should be set to null before the strategy is
nisse-webrtc 2017/09/12 10:39:05 Maybe these comments could make ownership clearer.
alexnarest 2017/09/14 13:08:33 Done.
alexnarest 2017/09/14 13:08:33 Done.
+ rtc::BitrateAllocationStrategy* bitrate_allocation_strategy) {
+ return RTCError(RTCErrorType::UNSUPPORTED_OPERATION);
+ }
+
// Returns the current SignalingState.
virtual SignalingState signaling_state() = 0;
virtual IceConnectionState ice_connection_state() = 0;
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | webrtc/call/bitrate_allocator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698