Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: webrtc/modules/pacing/paced_sender.h

Issue 2996643002: BWE allocation strategy
Patch Set: BWE allocation strategy Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/paced_sender.h
diff --git a/webrtc/modules/pacing/paced_sender.h b/webrtc/modules/pacing/paced_sender.h
index a1f7ebefec950197b8a2e2bda09ce3e4660181cd..ab6c174afa69e13f8e93f3bd6e9ff444d714a128 100644
--- a/webrtc/modules/pacing/paced_sender.h
+++ b/webrtc/modules/pacing/paced_sender.h
@@ -114,6 +114,12 @@ class PacedSender : public Module, public RtpPacketSender {
size_t bytes,
bool retransmission) override;
+ // Currently audio traffic is not accounted by pacer and passed through.
+ // With the introduction of audio BWE audio traffic will be accounted for
+ // the pacer budget calculation. The audio traffic still will be injected
+ // at high priority.
+ void SetAccountForAudioPackets(bool account_for_audio) override;
nisse-webrtc 2017/09/05 11:03:46 Unclear to me how this change is related to the BW
alexnarest 2017/09/05 13:37:46 The strategy allows us to enable audio BWE for vid
// Returns the time since the oldest queued packet was enqueued.
virtual int64_t QueueInMs() const;
@@ -198,6 +204,7 @@ class PacedSender : public Module, public RtpPacketSender {
float pacing_factor_ GUARDED_BY(critsect_);
int64_t queue_time_limit GUARDED_BY(critsect_);
+ bool account_for_audio_ GUARDED_BY(critsect_);
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698