BWE allocation strategy

webrtc/voice_engine/channel.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 303 matching lines @@
                     int64_t capture_time_ms,
                     size_t bytes,
                     bool retransmission) override {
     rtc::CritScope lock(&crit_);
     if (rtp_packet_sender_) {
       rtp_packet_sender_->InsertPacket(priority, ssrc, sequence_number,
                                        capture_time_ms, bytes, retransmission);
     }
   }
 
+  void AccountForAudioPackets(bool account_for_audio) override {

[stefan-webrtc, 2017/08/14 07:46:03]

I don't think this should ever be called as it's a proxy that only RtpRtcp uses
to access the real RtpPacketSender once it's available. RtpRtcp never calls this
method.

Maybe change to RTC_NOTREACHED() instead?

[alexnarest, 2017/08/15 06:02:37]

Done.

+    rtc::CritScope lock(&crit_);
+    if (rtp_packet_sender_) {
+      rtp_packet_sender_->AccountForAudioPackets(account_for_audio);
+    }
+  }
+
  private:
   rtc::ThreadChecker thread_checker_;
   rtc::CriticalSection crit_;
   RtpPacketSender* rtp_packet_sender_ GUARDED_BY(&crit_);
 };
 
 class VoERtcpObserver : public RtcpBandwidthObserver {
  public:
   explicit VoERtcpObserver(Channel* owner)
       : owner_(owner), bandwidth_observer_(nullptr) {}
@@ skipping 2806 matching lines @@
   int64_t min_rtt = 0;
   if (_rtpRtcpModule->RTT(remoteSSRC, &rtt, &avg_rtt, &min_rtt, &max_rtt) !=
       0) {
     return 0;
   }
   return rtt;
 }
 
 }  // namespace voe
 }  // namespace webrtc