BWE allocation strategy

webrtc/pc/peerconnection.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 1267 matching lines @@
   mask.min_bitrate_bps = bitrate.min_bitrate_bps;
   mask.start_bitrate_bps = bitrate.current_bitrate_bps;
   mask.max_bitrate_bps = bitrate.max_bitrate_bps;
 
   RTC_DCHECK(call_.get());
   call_->SetBitrateConfigMask(mask);
 
   return RTCError::OK();
 }
 
+RTCError PeerConnection::SetBitrateAllocationStrategy(
+    rtc::scoped_refptr<rtc::BitrateAllocationStrategy>
+        bitrate_allocation_strategy) {
+  rtc::Thread* worker_thread = factory_->worker_thread();

[stefan-webrtc, 2017/09/05 10:42:47]

Do we have to invoke SetBitrateAllocationStrategy on the worker thread if we
anyway make sure to do all the work on the worker_queue_ inside that method?

[alexnarest, 2017/09/05 13:37:46]

It looks like worker_thread and worker_queue_ are two different things. It could
be worker_thread is still needed here because of RTC_DCHECK(call_.get())

Probably deadbeef@ will know better.

+  if (!worker_thread->IsCurrent()) {
+    return worker_thread->Invoke<RTCError>(
+        RTC_FROM_HERE, rtc::Bind(&PeerConnection::SetBitrateAllocationStrategy,
+                                 this, bitrate_allocation_strategy));
+  }
+  RTC_DCHECK(call_.get());
+  call_->SetBitrateAllocationStrategy(bitrate_allocation_strategy);
+  return RTCError::OK();
+}
+
 bool PeerConnection::StartRtcEventLog(rtc::PlatformFile file,
                                       int64_t max_size_bytes) {
   return factory_->worker_thread()->Invoke<bool>(
       RTC_FROM_HERE, rtc::Bind(&PeerConnection::StartRtcEventLog_w, this, file,
                                max_size_bytes));
 }
 
 void PeerConnection::StopRtcEventLog() {
   factory_->worker_thread()->Invoke<void>(
       RTC_FROM_HERE, rtc::Bind(&PeerConnection::StopRtcEventLog_w, this));
@@ skipping 1225 matching lines @@
   return event_log_->StartLogging(file, max_size_bytes);
 }
 
 void PeerConnection::StopRtcEventLog_w() {
   if (event_log_) {
     event_log_->StopLogging();
   }
 }
 
 }  // namespace webrtc