Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: webrtc/api/video/video_timing.cc

Issue 2995953002: Revert of Add a flags field to video timing extension. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/video/video_timing.h ('k') | webrtc/common_video/include/video_frame.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/api/video/video_timing.h" 11 #include "webrtc/api/video/video_timing.h"
12 12
13 #include <sstream> 13 #include <sstream>
14 14
15 namespace webrtc { 15 namespace webrtc {
16 16
17 TimingFrameInfo::TimingFrameInfo() 17 TimingFrameInfo::TimingFrameInfo()
18 : rtp_timestamp(0), 18 : rtp_timestamp(0),
19 capture_time_ms(-1), 19 capture_time_ms(-1),
20 encode_start_ms(-1), 20 encode_start_ms(-1),
21 encode_finish_ms(-1), 21 encode_finish_ms(-1),
22 packetization_finish_ms(-1), 22 packetization_finish_ms(-1),
23 pacer_exit_ms(-1), 23 pacer_exit_ms(-1),
24 network_timestamp_ms(-1), 24 network_timestamp_ms(-1),
25 network2_timestamp_ms(-1), 25 network2_timestamp_ms(-1),
26 receive_start_ms(-1), 26 receive_start_ms(-1),
27 receive_finish_ms(-1), 27 receive_finish_ms(-1),
28 decode_start_ms(-1), 28 decode_start_ms(-1),
29 decode_finish_ms(-1), 29 decode_finish_ms(-1),
30 render_time_ms(-1), 30 render_time_ms(-1) {}
31 flags(TimingFrameFlags::kDefault) {}
32 31
33 int64_t TimingFrameInfo::EndToEndDelay() const { 32 int64_t TimingFrameInfo::EndToEndDelay() const {
34 return capture_time_ms >= 0 ? decode_finish_ms - capture_time_ms : -1; 33 return capture_time_ms >= 0 ? decode_finish_ms - capture_time_ms : -1;
35 } 34 }
36 35
37 bool TimingFrameInfo::IsLongerThan(const TimingFrameInfo& other) const { 36 bool TimingFrameInfo::IsLongerThan(const TimingFrameInfo& other) const {
38 int64_t other_delay = other.EndToEndDelay(); 37 int64_t other_delay = other.EndToEndDelay();
39 return other_delay == -1 || EndToEndDelay() > other_delay; 38 return other_delay == -1 || EndToEndDelay() > other_delay;
40 } 39 }
41 40
42 bool TimingFrameInfo::IsOutlier() const {
43 return !IsInvalid() && (flags & TimingFrameFlags::kTriggeredBySize);
44 }
45
46 bool TimingFrameInfo::IsTimerTriggered() const {
47 return !IsInvalid() && (flags & TimingFrameFlags::kTriggeredByTimer);
48 }
49
50 bool TimingFrameInfo::IsInvalid() const {
51 return flags == TimingFrameFlags::kInvalid;
52 }
53
54 std::string TimingFrameInfo::ToString() const { 41 std::string TimingFrameInfo::ToString() const {
55 std::stringstream out; 42 std::stringstream out;
56 if (IsInvalid()) { 43 out << rtp_timestamp << ',' << capture_time_ms << ',' << encode_start_ms
57 out << "[Invalid]"; 44 << ',' << encode_finish_ms << ',' << packetization_finish_ms << ','
58 } else { 45 << pacer_exit_ms << ',' << network_timestamp_ms << ','
59 out << rtp_timestamp << ',' << capture_time_ms << ',' << encode_start_ms 46 << network2_timestamp_ms << ',' << receive_start_ms << ','
60 << ',' << encode_finish_ms << ',' << packetization_finish_ms << ',' 47 << receive_finish_ms << ',' << decode_start_ms << ',' << decode_finish_ms
61 << pacer_exit_ms << ',' << network_timestamp_ms << ',' 48 << ',' << render_time_ms;
62 << network2_timestamp_ms << ',' << receive_start_ms << ','
63 << receive_finish_ms << ',' << decode_start_ms << ','
64 << decode_finish_ms << ',' << render_time_ms << ", outlier_triggered "
65 << IsOutlier() << ", timer_triggered " << IsTimerTriggered();
66 }
67 return out.str(); 49 return out.str();
68 } 50 }
69 51
70 } // namespace webrtc 52 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/video/video_timing.h ('k') | webrtc/common_video/include/video_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698