Ignore "b=AS:-1" instead of treating as a hard error.

webrtc/pc/webrtcsdp_unittest.cc

 /*
  *  Copyright 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 3325 matching lines @@
       "o=- 18446744069414584320 18446462598732840960 IN IP4 127.0.0.1\r\n"
       "s=-\r\n"
       "t=0 0\r\n"
       "m=video 3457 RTP/SAVPF 120\r\n"
       "b=AS:2147483647\r\n"
       "foo=fail\r\n";
 
   ExpectParseFailure(std::string(kSdpWithLargeBandwidth), "foo=fail");
 }
 
-// Similar to the above, except that negative values are illegal, not just
-// error-prone as large values are.
-// https://bugs.chromium.org/p/chromium/issues/detail?id=675361
-TEST_F(WebRtcSdpTest, DeserializingNegativeBandwidthLimitFails) {
+// Negative values for b=AS should be ignored, resulting in "kAutoBandwidth" in
+// the deserialized object. Applications historically may be using "b=AS:-1" to
+// mean "no bandwidth limit", but this is now what ommitting the attribute
+// entirely will do, so ignoring it will have the intended effect.
+TEST_F(WebRtcSdpTest, NegativeBandwidthLimitIgnored) {
   static const char kSdpWithNegativeBandwidth[] =
       "v=0\r\n"
       "o=- 18446744069414584320 18446462598732840960 IN IP4 127.0.0.1\r\n"
       "s=-\r\n"
       "t=0 0\r\n"
       "m=video 3457 RTP/SAVPF 120\r\n"
-      "b=AS:-1000\r\n";
+      "b=AS:-1234\r\n";
 
-  ExpectParseFailure(std::string(kSdpWithNegativeBandwidth), "b=AS:-1000");
+  JsepSessionDescription jdesc_output(kDummyString);
+  EXPECT_TRUE(SdpDeserialize(kSdpWithNegativeBandwidth, &jdesc_output));
+  const ContentInfo* vc = GetFirstVideoContent(jdesc_output.description());
+  ASSERT_NE(nullptr, vc);
+  const VideoContentDescription* vcd =
+      static_cast<const VideoContentDescription*>(vc->description);
+  EXPECT_EQ(cricket::kAutoBandwidth, vcd->bandwidth());
 }
 
 // Test that "ufrag"/"pwd" in the candidate line itself are ignored, and only
 // the "a=ice-ufrag"/"a=ice-pwd" attributes are used.
 // Regression test for:
 // https://bugs.chromium.org/p/chromium/issues/detail?id=681286
 TEST_F(WebRtcSdpTest, IceCredentialsInCandidateStringIgnored) {
   // Important piece is "ufrag foo pwd bar".
   static const char kSdpWithIceCredentialsInCandidateString[] =
       "v=0\r\n"
@@ skipping 184 matching lines @@
   EXPECT_TRUE(SdpDeserialize(message, &jdesc));
   auto audio_desc = static_cast<cricket::MediaContentDescription*>(
       jdesc.description()->GetContentByName(kAudioContentName)->description);
   auto video_desc = static_cast<cricket::MediaContentDescription*>(
       jdesc.description()->GetContentByName(kVideoContentName)->description);
   EXPECT_EQ(audio_desc_->connection_address().ToString(),
             audio_desc->connection_address().ToString());
   EXPECT_EQ(video_desc_->connection_address().ToString(),
             video_desc->connection_address().ToString());
 }