Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: webrtc/test/BUILD.gn

Issue 2995363002: Replace gflags usages with rtc_base/flags in all targets based on test_main (Closed)
Patch Set: Fix string use after free Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc ('k') | webrtc/test/test_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/BUILD.gn
diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
index f5c0afde4197ede3cedf411ab3f22aac8b0d7e28..fbff98e5e1fc4ae7bdb1bdc0c2854a125dd3bdf7 100644
--- a/webrtc/test/BUILD.gn
+++ b/webrtc/test/BUILD.gn
@@ -164,11 +164,8 @@ rtc_source_set("test_support") {
}
if (!build_with_chromium) {
- # This target depends on //third_party/gflags and since chromium does not
- # have gflags it causes an error when Gn parses this BUILD.gn file.
- # It seems that Gn eagerly tries to understand if all the targets are
- # buildable (even deps). Obviously gflags is not buildable in chromium
- # so if a target depends on this BUILD.gn file we hit this error.
+ # This target used to depend on //third_party/gflags which Chromium does not
+ # provide. TODO(oprypin): remove the conditional.
rtc_source_set("test_main") {
testonly = true
sources = [
@@ -184,7 +181,6 @@ if (!build_with_chromium) {
"../system_wrappers:metrics_default",
"//testing/gmock",
"//testing/gtest",
- "//third_party/gflags",
]
}
@@ -213,7 +209,6 @@ if (!build_with_chromium) {
"../system_wrappers",
"//testing/gmock",
"//testing/gtest",
- "//third_party/gflags",
]
if (!is_ios) {
@@ -252,7 +247,6 @@ if (!build_with_chromium) {
deps = [
":fileutils",
"../rtc_base:rtc_base_approved",
- "//third_party/gflags",
]
}
@@ -336,9 +330,9 @@ if (!build_with_chromium) {
":video_test_common",
":video_test_support",
"../modules/video_capture",
+ "../rtc_base:rtc_base_approved",
"//testing/gmock",
"//testing/gtest",
- "//third_party/gflags",
]
}
}
« no previous file with comments | « webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc ('k') | webrtc/test/test_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698