Index: webrtc/test/BUILD.gn |
diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn |
index f5c0afde4197ede3cedf411ab3f22aac8b0d7e28..fbff98e5e1fc4ae7bdb1bdc0c2854a125dd3bdf7 100644 |
--- a/webrtc/test/BUILD.gn |
+++ b/webrtc/test/BUILD.gn |
@@ -164,11 +164,8 @@ rtc_source_set("test_support") { |
} |
if (!build_with_chromium) { |
- # This target depends on //third_party/gflags and since chromium does not |
- # have gflags it causes an error when Gn parses this BUILD.gn file. |
- # It seems that Gn eagerly tries to understand if all the targets are |
- # buildable (even deps). Obviously gflags is not buildable in chromium |
- # so if a target depends on this BUILD.gn file we hit this error. |
+ # This target used to depend on //third_party/gflags which Chromium does not |
+ # provide. TODO(oprypin): remove the conditional. |
rtc_source_set("test_main") { |
testonly = true |
sources = [ |
@@ -184,7 +181,6 @@ if (!build_with_chromium) { |
"../system_wrappers:metrics_default", |
"//testing/gmock", |
"//testing/gtest", |
- "//third_party/gflags", |
] |
} |
@@ -213,7 +209,6 @@ if (!build_with_chromium) { |
"../system_wrappers", |
"//testing/gmock", |
"//testing/gtest", |
- "//third_party/gflags", |
] |
if (!is_ios) { |
@@ -252,7 +247,6 @@ if (!build_with_chromium) { |
deps = [ |
":fileutils", |
"../rtc_base:rtc_base_approved", |
- "//third_party/gflags", |
] |
} |
@@ -336,9 +330,9 @@ if (!build_with_chromium) { |
":video_test_common", |
":video_test_support", |
"../modules/video_capture", |
+ "../rtc_base:rtc_base_approved", |
"//testing/gmock", |
"//testing/gtest", |
- "//third_party/gflags", |
] |
} |
} |