Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: webrtc/modules/audio_coding/BUILD.gn

Issue 2995363002: Replace gflags usages with rtc_base/flags in all targets based on test_main (Closed)
Patch Set: Improve error messages Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/BUILD.gn
diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn
index 3e6a1834868daa33c7d2f9f2bf3d8460d665e4df..6f09b4ad55b8a0aa6e086cca42a08a2af4fc6683 100644
--- a/webrtc/modules/audio_coding/BUILD.gn
+++ b/webrtc/modules/audio_coding/BUILD.gn
@@ -1658,7 +1658,6 @@ if (rtc_include_tests) {
"../../rtc_base:rtc_base_approved",
"../../test:test_support",
"//testing/gtest",
- "//third_party/gflags",
]
}
@@ -1821,6 +1820,7 @@ if (rtc_include_tests) {
":neteq",
":neteq_test_tools",
":pcm16b",
+ "../../rtc_base:rtc_base_approved",
"../../system_wrappers:system_wrappers_default",
"//testing/gtest",
"//third_party/gflags:gflags",
@@ -1844,9 +1844,9 @@ if (rtc_include_tests) {
":neteq_quality_test_support",
":neteq_tools",
":webrtc_opus",
+ "../../rtc_base:rtc_base_approved",
"../../test:test_main",
"//testing/gtest",
- "//third_party/gflags",
]
}
@@ -1861,6 +1861,7 @@ if (rtc_include_tests) {
":neteq",
":neteq_test_support",
"../..:webrtc_common",
+ "../../rtc_base:rtc_base_approved",
"../../system_wrappers:system_wrappers_default",
"../../test:test_support",
"//third_party/gflags",
@@ -1884,7 +1885,6 @@ if (rtc_include_tests) {
"../../system_wrappers:system_wrappers_default",
"../../test:test_main",
"//testing/gtest",
- "//third_party/gflags",
]
}
@@ -1902,7 +1902,6 @@ if (rtc_include_tests) {
"../../rtc_base:rtc_base_approved",
"../../test:test_main",
"//testing/gtest",
- "//third_party/gflags",
]
}
@@ -1920,7 +1919,6 @@ if (rtc_include_tests) {
"../../rtc_base:rtc_base_approved",
"../../test:test_main",
"//testing/gtest",
- "//third_party/gflags",
]
}
@@ -2207,7 +2205,6 @@ if (rtc_include_tests) {
"../../test:test_support",
"//testing/gmock",
"//testing/gtest",
- "//third_party/gflags",
]
defines = audio_coding_defines

Powered by Google App Engine
This is Rietveld 408576698