Replace gflags usages with rtc_base/flags in all targets based on test_main

webrtc/test/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 import("//build/config/ui.gni")
@@ skipping 145 matching lines @@
 
   if (is_ios && !build_with_chromium) {
     deps += [ "../sdk:objc_common" ]
   }
 
   if (rtc_use_memcheck) {
     data = valgrind_webrtc_dependencies
   }
 }
 
 if (!build_with_chromium) {

[oprypin_webrtc, 2017/08/23 18:24:53]

I suspect that this condition should be removed now. Should I remove and dedent
the whole following block or is it more granular?

[kjellander_webrtc, 2017/08/24 07:31:34]

I think it can be removed, but to be on the safe side I'd prefer doing it in a
separate CL, we we don't end up reverting all this because of breaking the FYI
bots. Is that OK?

[oprypin_webrtc, 2017/08/24 08:29:56]

OK. Added comment with TODO.

-  # This target depends on //third_party/gflags and since chromium does not
-  # have gflags it causes an error when Gn parses this BUILD.gn file.
-  # It seems that Gn eagerly tries to understand if all the targets are
-  # buildable (even deps). Obviously gflags is not buildable in chromium
-  # so if a target depends on this BUILD.gn file we hit this error.
   rtc_source_set("test_main") {
     testonly = true
     sources = [
       "test_main.cc",
     ]
 
     public_deps = [
       ":test_support",
     ]
     deps = [
       ":field_trial",
       "../rtc_base:rtc_base_approved",
       "../system_wrappers:metrics_default",
       "//testing/gmock",
       "//testing/gtest",
-      "//third_party/gflags",
     ]
   }
 
   rtc_source_set("video_test_support") {
     testonly = true
 
     sources = [
       "testsupport/frame_reader.h",
       "testsupport/frame_writer.h",
       "testsupport/metrics/video_metrics.cc",
       "testsupport/metrics/video_metrics.h",
       "testsupport/mock/mock_frame_reader.h",
       "testsupport/mock/mock_frame_writer.h",
       "testsupport/y4m_frame_writer.cc",
       "testsupport/yuv_frame_reader.cc",
       "testsupport/yuv_frame_writer.cc",
     ]
 
     deps = [
       ":test_support",
       ":video_test_common",
       "..:webrtc_common",
       "../api:video_frame_api",
       "../common_video",
       "../rtc_base:rtc_base_approved",
       "../system_wrappers",
       "//testing/gmock",
       "//testing/gtest",
-      "//third_party/gflags",
     ]
 
     if (!is_ios) {
       deps += [ "//third_party:jpeg" ]
       sources += [ "testsupport/jpeg_frame_writer.cc" ]
     }
 
     public_deps = [
       ":fileutils",
     ]
@@ skipping 18 matching lines @@
 
   rtc_source_set("test_support_test_output") {
     testonly = true
     sources = [
       "testsupport/test_output.cc",
       "testsupport/test_output.h",
     ]
     deps = [
       ":fileutils",
       "../rtc_base:rtc_base_approved",
-      "//third_party/gflags",
     ]
   }
 
   test_support_unittests_resources = [
     "../../resources/foreman_cif_short.yuv",
     "../../resources/video_coding/frame-ethernet-ii.pcap",
     "../../resources/video_coding/frame-loopback.pcap",
     "../../resources/video_coding/pltype103.rtp",
     "../../resources/video_coding/pltype103_header_only.rtp",
     "../../resources/video_coding/ssrcs-2.pcap",
@@ skipping 63 matching lines @@
 
     deps += [
       ":direct_transport",
       ":fileutils_unittests",
       ":test_common",
       ":test_main",
       ":test_support_test_output",
       ":video_test_common",
       ":video_test_support",
       "../modules/video_capture",
+      "../rtc_base:rtc_base_approved",
       "//testing/gmock",
       "//testing/gtest",
-      "//third_party/gflags",
     ]
   }
 }
 
 rtc_source_set("fileutils") {
   testonly = true
   sources = [
     "testsupport/fileutils.cc",
     "testsupport/fileutils.h",
   ]
@@ skipping 277 matching lines @@
     java_files = [
       "android/org/webrtc/native_test/RTCNativeUnitTest.java",
       "android/org/webrtc/native_test/RTCNativeUnitTestActivity.java",
     ]
     deps = [
       "../rtc_base:base_java",
       "//testing/android/native_test:native_test_java",
     ]
   }
 }