Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: webrtc/rtc_base/moving_max_counter_unittest.cc

Issue 2995143002: Report max interframe delay over window insdead of interframe delay sum (Closed)
Patch Set: Implement more Kwiberg@ comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/rtc_base/moving_max_counter.h ('k') | webrtc/video/receive_statistics_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/rtc_base/moving_max_counter_unittest.cc
diff --git a/webrtc/rtc_base/moving_max_counter_unittest.cc b/webrtc/rtc_base/moving_max_counter_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..54dbe7e7dab2533742197772189111e2bdd6b734
--- /dev/null
+++ b/webrtc/rtc_base/moving_max_counter_unittest.cc
@@ -0,0 +1,57 @@
+/*
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/rtc_base/moving_max_counter.h"
+#include "webrtc/test/gtest.h"
+
+TEST(MovingMaxCounter, ReportsMaximumInTheWindow) {
+ rtc::MovingMaxCounter<int> counter(100);
+ counter.Add(1, 1);
+ EXPECT_EQ(counter.Max(1), rtc::Optional<int>(1));
+ counter.Add(2, 30);
+ EXPECT_EQ(counter.Max(30), rtc::Optional<int>(2));
+ counter.Add(100, 60);
+ EXPECT_EQ(counter.Max(60), rtc::Optional<int>(100));
+ counter.Add(4, 70);
+ EXPECT_EQ(counter.Max(70), rtc::Optional<int>(100));
+ counter.Add(5, 90);
+ EXPECT_EQ(counter.Max(90), rtc::Optional<int>(100));
+}
+
+TEST(MovingMaxCounter, IgnoresOldElements) {
+ rtc::MovingMaxCounter<int> counter(100);
+ counter.Add(1, 1);
+ counter.Add(2, 30);
+ counter.Add(100, 60);
+ counter.Add(4, 70);
+ counter.Add(5, 90);
+ EXPECT_EQ(counter.Max(160), rtc::Optional<int>(100));
+ // 100 is now out of the window. Next maximum is 5.
+ EXPECT_EQ(counter.Max(161), rtc::Optional<int>(5));
+}
+
+TEST(MovingMaxCounter, HandlesEmptyWindow) {
+ rtc::MovingMaxCounter<int> counter(100);
+ counter.Add(123, 1);
+ EXPECT_TRUE(counter.Max(101).has_value());
+ EXPECT_FALSE(counter.Max(102).has_value());
+}
+
+TEST(MovingMaxCounter, HandlesSamplesWithEqualTimestamps) {
+ rtc::MovingMaxCounter<int> counter(100);
+ counter.Add(2, 30);
+ EXPECT_EQ(counter.Max(30), rtc::Optional<int>(2));
+ counter.Add(5, 30);
+ EXPECT_EQ(counter.Max(30), rtc::Optional<int>(5));
+ counter.Add(4, 30);
+ EXPECT_EQ(counter.Max(30), rtc::Optional<int>(5));
+ counter.Add(1, 90);
+ EXPECT_EQ(counter.Max(150), rtc::Optional<int>(1));
+}
« no previous file with comments | « webrtc/rtc_base/moving_max_counter.h ('k') | webrtc/video/receive_statistics_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698