Report max interframe delay over window insdead of interframe delay sum

webrtc/rtc_base/moving_max_counter_unittest.cc

+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/rtc_base/moving_max_counter.h"
+#include "webrtc/test/gtest.h"
+
+TEST(MovingMaxCounter, ReportsMaximumInTheWindow) {
+  rtc::MovingMaxCounter<int> counter(100);
+  counter.Add(1, 1);
+  EXPECT_EQ(counter.Max(1).value_or(-1), 1);

[kwiberg-webrtc, 2017/08/22 11:13:30]

You can write this sort of thing as

  EXPECT_EQ(rtc::Optional<int>(1), counter.Max(1));

That way, it's obvious to the reader that you're expecting an Optional that
contains the specified value.

[ilnik, 2017/08/22 12:03:56]

Cool, it never occurred to me to compare optionals directly.

+  counter.Add(2, 30);
+  EXPECT_EQ(counter.Max(30).value_or(-1), 2);
+  counter.Add(100, 60);
+  EXPECT_EQ(counter.Max(60).value_or(-1), 100);
+  counter.Add(4, 70);
+  EXPECT_EQ(counter.Max(70).value_or(-1), 100);
+  counter.Add(5, 90);
+  EXPECT_EQ(counter.Max(90).value_or(-1), 100);
+}
+
+TEST(MovingMaxCounter, IgnoresOldElements) {
+  rtc::MovingMaxCounter<int> counter(100);
+  counter.Add(1, 1);
+  counter.Add(2, 30);
+  counter.Add(100, 60);
+  counter.Add(5, 70);
+  counter.Add(4, 90);
+  EXPECT_EQ(counter.Max(160).value_or(-1), 100);
+  // 100 is now out of the window.
+  EXPECT_EQ(*counter.Max(161), 5);
+}
+
+TEST(MovingMaxCounter, HandlesEmptyWindow) {
+  rtc::MovingMaxCounter<int> counter(100);
+  counter.Add(123, 1);
+  EXPECT_TRUE(counter.Max(101).has_value());
+  EXPECT_FALSE(counter.Max(102).has_value());
+}
+
+TEST(MovingMaxCounter, HandlesSamplesWithEqualTimestamps) {
+  rtc::MovingMaxCounter<int> counter(100);
+  counter.Add(2, 30);
+  EXPECT_EQ(counter.Max(30).value_or(-1), 2);
+  counter.Add(5, 30);
+  EXPECT_EQ(counter.Max(30).value_or(-1), 5);
+  counter.Add(4, 30);
+  EXPECT_EQ(counter.Max(30).value_or(-1), 5);
+  counter.Add(1, 90);
+  EXPECT_EQ(counter.Max(150).value_or(-1), 1);
+}