Report max interframe delay over window insdead of interframe delay sum

webrtc/video/receive_statistics_proxy.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_VIDEO_RECEIVE_STATISTICS_PROXY_H_
 #define WEBRTC_VIDEO_RECEIVE_STATISTICS_PROXY_H_
 
 #include <map>
 #include <string>
 
 #include "webrtc/call/video_receive_stream.h"
 #include "webrtc/common_types.h"
 #include "webrtc/common_video/include/frame_callback.h"
 #include "webrtc/modules/video_coding/include/video_coding_defines.h"
 #include "webrtc/rtc_base/criticalsection.h"
+#include "webrtc/rtc_base/moving_max_counter.h"
 #include "webrtc/rtc_base/rate_statistics.h"
 #include "webrtc/rtc_base/ratetracker.h"
 #include "webrtc/rtc_base/thread_annotations.h"
 #include "webrtc/video/quality_threshold.h"
 #include "webrtc/video/report_block_stats.h"
 #include "webrtc/video/stats_counter.h"
 #include "webrtc/video/video_stream_decoder.h"
 
 namespace webrtc {
 
@@ skipping 113 matching lines @@
   SampleCounter current_delay_counter_ GUARDED_BY(crit_);
   SampleCounter delay_counter_ GUARDED_BY(crit_);
   SampleCounter e2e_delay_counter_video_ GUARDED_BY(crit_);
   SampleCounter e2e_delay_counter_screenshare_ GUARDED_BY(crit_);
   SampleCounter interframe_delay_counter_video_ GUARDED_BY(crit_);
   SampleCounter interframe_delay_counter_screenshare_ GUARDED_BY(crit_);
   int64_t e2e_delay_max_ms_video_ GUARDED_BY(crit_);
   int64_t e2e_delay_max_ms_screenshare_ GUARDED_BY(crit_);
   int64_t interframe_delay_max_ms_video_  GUARDED_BY(crit_);
   int64_t interframe_delay_max_ms_screenshare_  GUARDED_BY(crit_);
+  rtc::MovingMaxCounter<int> interframe_delay_max_moving_ GUARDED_BY(crit_);

[kwiberg-webrtc, 2017/08/22 21:40:47]

What if you made this one mutable instead, and made MovingMaxCounter::Max()
non-const?

This class uses the counter responsibly---always passing the current time,
calling Max() but not Add() from const methods---so its callers will not observe
any const conventions being broken.

[ilnik, 2017/08/23 07:46:50]

Yes, this is a great idea. Done it.

   MaxCounter freq_offset_counter_ GUARDED_BY(crit_);
   int64_t first_report_block_time_ms_ GUARDED_BY(crit_);
   ReportBlockStats report_block_stats_ GUARDED_BY(crit_);
   QpCounters qp_counters_;  // Only accessed on the decoding thread.
   std::map<uint32_t, StreamDataCounters> rtx_stats_ GUARDED_BY(crit_);
   int64_t avg_rtt_ms_ GUARDED_BY(crit_);
   mutable std::map<int64_t, size_t> frame_window_ GUARDED_BY(&crit_);
   VideoContentType last_content_type_ GUARDED_BY(&crit_);
   rtc::Optional<int64_t> last_decoded_frame_time_ms_;
   rtc::Optional<TimingFrameInfo> timing_frame_info_ GUARDED_BY(&crit_);
 };
 
 }  // namespace webrtc
 #endif  // WEBRTC_VIDEO_RECEIVE_STATISTICS_PROXY_H_