Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: webrtc/video/report_block_stats.cc

Issue 2994633002: Renamed fields in rtp_rtcp_defines.h/RTCPReportBlock (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/report_block_stats.cc
diff --git a/webrtc/video/report_block_stats.cc b/webrtc/video/report_block_stats.cc
index f36feb9e6738c5223e51d8243f01936cfae40b0f..ac5041d7fbfa2173cf1f6d1e4af07b56d2676fb1 100644
--- a/webrtc/video/report_block_stats.cc
+++ b/webrtc/video/report_block_stats.cc
@@ -34,12 +34,13 @@ void ReportBlockStats::Store(const RtcpStatistics& rtcp_stats,
uint32_t remote_ssrc,
uint32_t source_ssrc) {
RTCPReportBlock block;
- block.cumulativeLost = rtcp_stats.packets_lost;
- block.fractionLost = rtcp_stats.fraction_lost;
- block.extendedHighSeqNum = rtcp_stats.extended_highest_sequence_number;
+ block.packets_lost = rtcp_stats.packets_lost;
+ block.fraction_lost = rtcp_stats.fraction_lost;
+ block.extended_highest_sequence_number =
+ rtcp_stats.extended_highest_sequence_number;
block.jitter = rtcp_stats.jitter;
- block.remoteSSRC = remote_ssrc;
- block.sourceSSRC = source_ssrc;
+ block.sender_ssrc = remote_ssrc;
+ block.source_ssrc = source_ssrc;
uint32_t num_sequence_numbers = 0;
uint32_t num_lost_sequence_numbers = 0;
StoreAndAddPacketIncrement(
@@ -56,7 +57,7 @@ RTCPReportBlock ReportBlockStats::AggregateAndStore(
uint32_t num_lost_sequence_numbers = 0;
ReportBlockVector::const_iterator report_block = report_blocks.begin();
for (; report_block != report_blocks.end(); ++report_block) {
- aggregate.cumulativeLost += report_block->cumulativeLost;
+ aggregate.packets_lost += report_block->packets_lost;
aggregate.jitter += report_block->jitter;
StoreAndAddPacketIncrement(*report_block,
&num_sequence_numbers,
@@ -68,7 +69,7 @@ RTCPReportBlock ReportBlockStats::AggregateAndStore(
return report_blocks[0];
}
// Fraction lost since previous report block.
- aggregate.fractionLost =
+ aggregate.fraction_lost =
FractionLost(num_lost_sequence_numbers, num_sequence_numbers);
aggregate.jitter = static_cast<uint32_t>(
(aggregate.jitter + report_blocks.size() / 2) / report_blocks.size());
@@ -80,13 +81,14 @@ void ReportBlockStats::StoreAndAddPacketIncrement(
uint32_t* num_sequence_numbers,
uint32_t* num_lost_sequence_numbers) {
// Get diff with previous report block.
- ReportBlockMap::iterator prev_report_block = prev_report_blocks_.find(
- report_block.sourceSSRC);
+ ReportBlockMap::iterator prev_report_block =
+ prev_report_blocks_.find(report_block.source_ssrc);
if (prev_report_block != prev_report_blocks_.end()) {
- int seq_num_diff = report_block.extendedHighSeqNum -
- prev_report_block->second.extendedHighSeqNum;
- int cum_loss_diff = report_block.cumulativeLost -
- prev_report_block->second.cumulativeLost;
+ int seq_num_diff =
+ report_block.extended_highest_sequence_number -
+ prev_report_block->second.extended_highest_sequence_number;
+ int cum_loss_diff =
+ report_block.packets_lost - prev_report_block->second.packets_lost;
if (seq_num_diff >= 0 && cum_loss_diff >= 0) {
*num_sequence_numbers += seq_num_diff;
*num_lost_sequence_numbers += cum_loss_diff;
@@ -96,7 +98,7 @@ void ReportBlockStats::StoreAndAddPacketIncrement(
}
}
// Store current report block.
- prev_report_blocks_[report_block.sourceSSRC] = report_block;
+ prev_report_blocks_[report_block.source_ssrc] = report_block;
}
int ReportBlockStats::FractionLostInPercent() const {

Powered by Google App Engine
This is Rietveld 408576698